Issue #447: EHH - TypeError: properties is undefined in composer.js

chrome/content/composer.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 let {Prefs} = require("prefs");
 
 let domainData;
 let nodeData;
@@ skipping 92 matching lines @@
   else {
     obj.__defineGetter__(key, function() {
       return orig[key];
     });
     obj.__defineSetter__(key, function(value) {
       orig[key] = value;
     });
   }
 }
 
-var atomService = Cc["@mozilla.org/atom-service;1"].getService(Ci.nsIAtomService);
-var selectedAtom = atomService.getAtom("selected-false");
-var anchorAtom = atomService.getAtom("anchor");
-
-function TreeView_getRowProperties(row, properties) {
+function TreeView_getRowProperties(row) {

[Wladimir Palant, 2014/06/18 17:20:48]

Element Hiding Helper currently supports Firefox 20. Please update
metadata.gecko for this extension to match the version requirements of Adblock
Plus.

[saroyanm, 2014/06/19 07:24:26]

Done.

+  let property = "";
   if (!this.selection.isSelected(row))
-    properties.AppendElement(selectedAtom);
+    property += "selected-false";

[Wladimir Palant, 2014/06/18 17:20:48]

Given that we no longer need atoms for all properties, this can be simpler:

let properties = "selected-" + this.selection.isSelected(row);

Then you won't need to check whether property is empty below.

Note that I named the variable "properties" above, it should be plural.

[saroyanm, 2014/06/19 07:24:26]

Good point, 
Thanks. 

 
   var item = this.getItemAtIndex(row);
   if (item && (item.nodeData.expression != "*" || item.nodeData == nodeData))
-    properties.AppendElement(anchorAtom);
+    property += (property ? " anchor" : "anchor");
+
+  return property;
 }
 
-function TreeView_getCellProperties(row, col, properties) {
-  this.getRowProperties(row, properties);
+function TreeView_getCellProperties(row, col) {
+  this.getRowProperties(row);
 }
 
 /*********************
  * General functions *
  *********************/
 
 function init() {
   var element = window.arguments[0];
   doc = element.ownerDocument;
   var wnd = doc.defaultView;
@@ skipping 497 matching lines @@
 
   fillAttributes(item.nodeData);
 }
 
 function addExpression()
 {
   AdblockPlus.addPatterns([document.getElementById("expression").value]);
 
   togglePreview(false);
 }