Issue #447: EHH - TypeError: properties is undefined in composer.js

This issue is related to current ticket:
https://issues.adblockplus.org/ticket/447

[saroyanm, 2014-06-18 16:09:35]

Wladimir can you please have a look on this patch.

Seams like "getRowProperties" method's "property" attribute in nsITreeView
interface is deprecated since FF v22, which we not support, instead we can
return space separated property according to current documentation:
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interfa...

[saroyanm, 2014-06-18 16:20:49]

On 2014/06/18 16:09:35, saroyanm wrote:
> Wladimir can you please have a look on this patch.
> 
> Seams like "getRowProperties" method's "property" attribute in nsITreeView
> interface is deprecated since FF v22, which we not support, instead we can
> return space separated property according to current documentation:
>
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interfa...)

Correction:
We do not support Below V22.

[Wladimir Palant, 2014-06-18 17:20:47]

http://codereview.adblockplus.org/5728222025089024/diff/5629499534213120/chro...
File chrome/content/composer.js (right):

http://codereview.adblockplus.org/5728222025089024/diff/5629499534213120/chro...
chrome/content/composer.js:113: function TreeView_getRowProperties(row) {
Element Hiding Helper currently supports Firefox 20. Please update
metadata.gecko for this extension to match the version requirements of Adblock
Plus.

http://codereview.adblockplus.org/5728222025089024/diff/5629499534213120/chro...
chrome/content/composer.js:116: property += "selected-false";
Given that we no longer need atoms for all properties, this can be simpler:

let properties = "selected-" + this.selection.isSelected(row);

Then you won't need to check whether property is empty below.

Note that I named the variable "properties" above, it should be plural.

[saroyanm, 2014-06-19 07:24:26]

Hope we can give a go with last patch.

http://codereview.adblockplus.org/5728222025089024/diff/5629499534213120/chro...
File chrome/content/composer.js (right):

http://codereview.adblockplus.org/5728222025089024/diff/5629499534213120/chro...
chrome/content/composer.js:113: function TreeView_getRowProperties(row) {
On 2014/06/18 17:20:48, Wladimir Palant wrote:
> Element Hiding Helper currently supports Firefox 20. Please update
> metadata.gecko for this extension to match the version requirements of Adblock
> Plus.

Done.

http://codereview.adblockplus.org/5728222025089024/diff/5629499534213120/chro...
chrome/content/composer.js:116: property += "selected-false";
On 2014/06/18 17:20:48, Wladimir Palant wrote:
> Given that we no longer need atoms for all properties, this can be simpler:
> 
> let properties = "selected-" + this.selection.isSelected(row);
> 
> Then you won't need to check whether property is empty below.
> 
> Note that I named the variable "properties" above, it should be plural.

Good point, 
Thanks.

[Wladimir Palant, 2014-06-19 08:35:55]

LGTM