Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Issue 5730260331003904: Issue 2419 - Show newly downloaded notifications immediately (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Felix Dahlke
Modified:
4 years, 3 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2419 - Show newly downloaded notifications immediately

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M lib/notification.js View 3 chunks +2 lines, -7 lines 1 comment Download

Messages

Total messages: 2
Felix Dahlke
http://codereview.adblockplus.org/5730260331003904/diff/5629499534213120/lib/notification.js File lib/notification.js (left): http://codereview.adblockplus.org/5730260331003904/diff/5629499534213120/lib/notification.js#oldcode91 lib/notification.js:91: notificationTimer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer); While we had IIRC discussed that ...
4 years, 3 months ago (2015-06-08 20:06:23 UTC) #1
Wladimir Palant
4 years, 3 months ago (2015-06-08 20:48:46 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5