Issue 5731052198821888: #1203 - Establish nginx::hostconfig-fragment() directive

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5731052198821888: #1203 - Establish nginx::hostconfig-fragment() directive (Closed)

Created:
Aug. 13, 2014, 9:07 a.m. by mathias

Modified:
Aug. 18, 2014, 11:42 a.m.

Reviewers:
Wladimir Palant

CC:
Felix Dahlke

Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/1203#ticket

Patch Set 2 : #1203 - Migrate Trac setup to nginx::hostconfig-fragment #

Patch Set 3 : #1203 - Establish nginx::hostconfig-fragment() directive #

Total comments: 2

Patch Set 4 : #1203 - Establish nginx::hostconfig-fragment() directive #

Created: Aug. 18, 2014, 10:01 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -17 lines)			Patch
M	modules/nginx/manifests/init.pp	View	1 2	3 chunks	+26 lines, -1 line	0 comments	Download
M	modules/nginx/templates/site.erb	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	modules/trac/manifests/init.pp	View	1 2 3	3 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/5731052198821888/diff/5639274879778816/modules/trac/manifests/init.pp File modules/trac/manifests/init.pp (right): http://codereview.adblockplus.org/5731052198821888/diff/5639274879778816/modules/trac/manifests/init.pp#newcode144 modules/trac/manifests/init.pp:144: nginx::hostconfig-fragment {"nginx_fragment_$name": No need to duplicate "nginx_fragment" in the ...

Aug. 14, 2014, 8:33 p.m. (2014-08-14 20:33:50 UTC) #4

mathias

See https://issues.adblockplus.org/ticket/1203#ticket

Aug. 18, 2014, 10:01 a.m. (2014-08-18 10:01:46 UTC) #5

mathias

Aug. 18, 2014, 10:03 a.m. (2014-08-18 10:03:26 UTC) #6

Wladimir Palant

Aug. 18, 2014, 11:42 a.m. (2014-08-18 11:42:21 UTC) #7

While the change itself looks fine, it doesn't seem that we want the additional
abstraction here. See https://issues.adblockplus.org/ticket/1203#comment:5 and
below.

Expand All Messages | Collapse All Messages