Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(206)

Issue 5733084272001024: Issue 2368 - Update adblockplus dependency to revision feb391127fe4 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Felix Dahlke
Modified:
4 years, 5 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 2368 - Update adblockplus dependency to revision feb391127fe4

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Make URL mandatory #

Total comments: 6

Patch Set 3 : Fix doc comment issues #

Patch Set 4 : Hint that there may not be a notification for the supplied URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M lib/notificationHelper.js View 1 2 3 3 chunks +25 lines, -19 lines 0 comments Download
M webrequest.js View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10
Felix Dahlke
4 years, 5 months ago (2015-06-12 07:27:18 UTC) #1
Sebastian Noack
LGTM, but too late to land before the 1.9 release. Please push afterwards.
4 years, 5 months ago (2015-06-12 09:29:24 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5733084272001024/diff/6270652252160000/lib/notificationHelper.js File lib/notificationHelper.js (right): http://codereview.adblockplus.org/5733084272001024/diff/6270652252160000/lib/notificationHelper.js#newcode229 lib/notificationHelper.js:229: NotificationStorage.showNext(url && stringifyURL(url)); Oh wait, I were too quick. ...
4 years, 5 months ago (2015-06-12 09:42:06 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5733084272001024/diff/6270652252160000/lib/notificationHelper.js File lib/notificationHelper.js (right): http://codereview.adblockplus.org/5733084272001024/diff/6270652252160000/lib/notificationHelper.js#newcode229 lib/notificationHelper.js:229: NotificationStorage.showNext(url && stringifyURL(url)); On 2015/06/12 09:42:06, Sebastian Noack wrote: ...
4 years, 5 months ago (2015-06-12 09:42:42 UTC) #4
Felix Dahlke
New patch set. http://codereview.adblockplus.org/5733084272001024/diff/6270652252160000/lib/notificationHelper.js File lib/notificationHelper.js (right): http://codereview.adblockplus.org/5733084272001024/diff/6270652252160000/lib/notificationHelper.js#newcode229 lib/notificationHelper.js:229: NotificationStorage.showNext(url && stringifyURL(url)); On 2015/06/12 09:42:42, ...
4 years, 5 months ago (2015-06-12 17:01:34 UTC) #5
Sebastian Noack
http://codereview.adblockplus.org/5733084272001024/diff/5639274879778816/lib/notificationHelper.js File lib/notificationHelper.js (right): http://codereview.adblockplus.org/5733084272001024/diff/5639274879778816/lib/notificationHelper.js#newcode223 lib/notificationHelper.js:223: * Shows the next notification for the supplied URL, ...
4 years, 5 months ago (2015-06-12 17:14:19 UTC) #6
Felix Dahlke
New patch set is up. http://codereview.adblockplus.org/5733084272001024/diff/5639274879778816/lib/notificationHelper.js File lib/notificationHelper.js (right): http://codereview.adblockplus.org/5733084272001024/diff/5639274879778816/lib/notificationHelper.js#newcode223 lib/notificationHelper.js:223: * Shows the next ...
4 years, 5 months ago (2015-06-12 17:56:10 UTC) #7
Sebastian Noack
http://codereview.adblockplus.org/5733084272001024/diff/5639274879778816/lib/notificationHelper.js File lib/notificationHelper.js (right): http://codereview.adblockplus.org/5733084272001024/diff/5639274879778816/lib/notificationHelper.js#newcode223 lib/notificationHelper.js:223: * Shows the next notification for the supplied URL, ...
4 years, 5 months ago (2015-06-12 18:12:50 UTC) #8
Felix Dahlke
http://codereview.adblockplus.org/5733084272001024/diff/5639274879778816/lib/notificationHelper.js File lib/notificationHelper.js (right): http://codereview.adblockplus.org/5733084272001024/diff/5639274879778816/lib/notificationHelper.js#newcode223 lib/notificationHelper.js:223: * Shows the next notification for the supplied URL, ...
4 years, 5 months ago (2015-06-12 18:24:08 UTC) #9
Sebastian Noack
4 years, 5 months ago (2015-06-12 18:49:43 UTC) #10
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5