Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: modules/updateserver/files/logrotate
Issue
5734493784637440
:
Issue 245 - Unify SSL configuration for all servers (Closed)
Patch Set: Converted Nagios site configuration and centralized error page configuration
Created April 10, 2014, 6:40 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Converted Nagios site configuration and centralized error page configuration
Right:
Patch Set 1: None
Patch Set 2: Converted Nagios site configuration and centralized error page configuration
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
manifests/codereviewserver.pp
manifests/downloadserver.pp
manifests/monitoringserver.pp
manifests/statsserver.pp
manifests/updateserver.pp
modules/discourse/files/logrotate
modules/discourse/files/site.conf
modules/discourse/manifests/init.pp
modules/downloadserver/files/logrotate
modules/downloadserver/files/site.conf
modules/downloadserver/manifests/init.pp
modules/filterserver/files/logrotate
modules/filterserver/files/site.conf
modules/filterserver/manifests/init.pp
modules/nagios/files/site.conf
modules/nagios/manifests/server.pp
modules/nginx/manifests/init.pp
modules/nginx/templates/logrotate.erb
modules/nginx/templates/site.erb
modules/notificationserver/files/logrotate
modules/notificationserver/files/site.conf
modules/notificationserver/manifests/init.pp
modules/rietveld/files/site.conf
modules/rietveld/manifests/init.pp
modules/statsmaster/files/logrotate
modules/statsmaster/files/site.conf
modules/statsmaster/manifests/init.pp
modules/trac/files/site.conf
modules/trac/manifests/init.pp
modules/updateserver/files/logrotate
modules/updateserver/files/site.conf
modules/updateserver/manifests/init.pp
modules/web/manifests/server.pp
modules/web/templates/global.conf.erb
modules/web/templates/site.conf.erb
View unified diff
|
Download patch
« no previous file with comments
|
« modules/trac/manifests/init.pp
('k') |
modules/updateserver/files/site.conf »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
/var/log/nginx/access_log_update {
2
daily
3
rotate 30
4
compress
5
missingok
6
nodateext
7
sharedscripts
8
postrotate
9
[ ! -f /var/run/nginx.pid ] || kill -USR1 `cat /var/run/nginx.pid`
10
endscript
11
}
OLD
NEW
« no previous file with comments
|
« modules/trac/manifests/init.pp
('k') |
modules/updateserver/files/site.conf »
('j') |
no next file with comments »
Edit Message
Issue 5734493784637440: Issue 245 - Unify SSL configuration for all servers (Closed)
Created April 2, 2014, 2:05 p.m. by Wladimir Palant
Modified April 10, 2014, 9:07 a.m.
Reviewers: Felix Dahlke
Base URL:
Comments: 2
This is Rietveld