Issue 1374 - Don`t hardcode web handlers for multiplexer

Issue 1374 - Don`t hardcode web handlers for multiplexer

[Sebastian Noack, 2014-09-18 16:05:37]

http://codereview.adblockplus.org/5744805892063232/diff/5629499534213120/site...
File sitescripts/utils.py (right):

http://codereview.adblockplus.org/5744805892063232/diff/5629499534213120/site...
sitescripts/utils.py:76: config.optionxform = str
Why is this necessary? Won't that break for options with non-ASCII charterers?

[Wladimir Palant, 2014-09-18 18:04:14]

http://codereview.adblockplus.org/5744805892063232/diff/5629499534213120/site...
File sitescripts/utils.py (right):

http://codereview.adblockplus.org/5744805892063232/diff/5629499534213120/site...
sitescripts/utils.py:76: config.optionxform = str
On 2014/09/18 16:05:37, Sebastian Noack wrote:
> Why is this necessary? Won't that break for options with non-ASCII charterers?

By default, SafeConfigParser will lower-case all option names in order to treat
them case-insensitively - this will mangle module names. Using str for
optionxform is actually the recommendation in the ConfigParser documentation to
disable this behavior. And - yes, this only works as long as all option names
use ASCII. However, the config.read() call below reads the file as ASCII so if
we want to allow Unicode we need to fix that as well.

[Sebastian Noack, 2014-09-18 19:01:06]

http://codereview.adblockplus.org/5744805892063232/diff/5629499534213120/site...
File sitescripts/utils.py (right):

http://codereview.adblockplus.org/5744805892063232/diff/5629499534213120/site...
sitescripts/utils.py:76: config.optionxform = str
On 2014/09/18 18:04:14, Wladimir Palant wrote:
> On 2014/09/18 16:05:37, Sebastian Noack wrote:
> > Why is this necessary? Won't that break for options with non-ASCII
charterers?
> 
> By default, SafeConfigParser will lower-case all option names in order to
treat
> them case-insensitively - this will mangle module names. Using str for
> optionxform is actually the recommendation in the ConfigParser documentation
to
> disable this behavior. And - yes, this only works as long as all option names
> use ASCII. However, the config.read() call below reads the file as ASCII so if
> we want to allow Unicode we need to fix that as well.

How about a simple no-op?

config.optionxform = lambda x: x

[Wladimir Palant, 2014-09-18 19:12:21]

http://codereview.adblockplus.org/5744805892063232/diff/5629499534213120/site...
File sitescripts/utils.py (right):

http://codereview.adblockplus.org/5744805892063232/diff/5629499534213120/site...
sitescripts/utils.py:76: config.optionxform = str
On 2014/09/18 19:01:07, Sebastian Noack wrote:
> How about a simple no-op?

Sounds like a good compromise. This will allow using bogus option names like
calling .set_option("foo", {}, "True") but we don't really care here.

[Sebastian Noack, 2014-09-18 20:45:15]

LGTM