Issue 2602 - Extend Shadow DOM workaround to all Google subdomains

Issue 2602 - Extend Shadow DOM workaround to all Google subdomains

[kzar, 2015-06-12 12:13:32]

I don't know the specifics about this problem to know if the regexp is suitable,
for example are any google.co.uk subdomains broken by this problem? But the
regexp seems to work as expected and I can't see any problems so LGTM

[Sebastian Noack, 2015-06-12 12:23:03]

On 2015/06/12 12:13:32, kzar wrote:
> I don't know the specifics about this problem to know if the regexp is
suitable,
> for example are any google.co.uk subdomains broken by this problem? But the
> regexp seems to work as expected and I can't see any problems so LGTM

The details are in the comments of the issue. Apparently at least
inbox.google.com and productforums.google.com are affected as well. So to keep
the logic simple here, and in case more subdomains are effected, I went with
simply checking for *.google.com.

If you are aware of any Google service that uses their feedback functionality -
which causes the issue we are working around here - that isn't covered by that
regular expression let me know. But at least Gmail and product forums are only
available under the google.com domain.

[kzar, 2015-06-12 12:27:46]

On 2015/06/12 12:23:03, Sebastian Noack wrote:
> On 2015/06/12 12:13:32, kzar wrote:
> > I don't know the specifics about this problem to know if the regexp is
> suitable,
> > for example are any google.co.uk subdomains broken by this problem? But the
> > regexp seems to work as expected and I can't see any problems so LGTM
> 
> The details are in the comments of the issue. Apparently at least
> http://inbox.google.com and http://productforums.google.com are affected as
well. So to keep
> the logic simple here, and in case more subdomains are effected, I went with
> simply checking for *.google.com.
> 
> If you are aware of any Google service that uses their feedback functionality
-
> which causes the issue we are working around here - that isn't covered by that
> regular expression let me know. But at least Gmail and product forums are only
> available under the http://google.com domain.

I have read the issue. I can't think of any non google.com examples either, just
thought it was possible and therefore worth mentioning. Yea, it still LGTM.