Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include.preload.js

Issue 5755650030174208: Issue 2602 - Extend Shadow DOM workaround to all Google subdomains (Closed)
Patch Set: Created June 12, 2015, 12:04 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include.preload.js
===================================================================
--- a/include.preload.js
+++ b/include.preload.js
@@ -292,12 +292,9 @@
// However, creating a shadow root breaks running CSS transitions. So we
// have to create the shadow root before transistions might start (#452).
//
- // Also, we can't use shadow DOM on Google Docs since it breaks printing
- // there (#1770), and Google Mail since the feedback from breaks the layout
- // there when using shadow DOM (#2602).
- if ("createShadowRoot" in document.documentElement
- && document.domain != "docs.google.com"
- && document.domain != "mail.google.com")
+ // Also, using shadow DOM causes issues on some Google websites,
+ // including Goolgle Docs and Gmail (#1770, #2602).
+ if ("createShadowRoot" in document.documentElement && !/\.google\.com$/.test(document.domain))
{
shadow = document.documentElement.createShadowRoot();
shadow.appendChild(document.createElement("shadow"));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld