Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5765952465534976: Issue #276 - Introduce ATL_Deprecate.h (Closed)

Created:
July 24, 2014, 2:06 p.m. by Eric
Modified:
July 25, 2014, 9:57 p.m.
Visibility:
Public.

Description

Part of issue #276 - Stop using ATL Introduce ATL_Deprecate.h, a header that isolates ATL dependencies. When this header can be removed, issue #276 is finished.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -5 lines) Patch
M adblockplus.gyp View 1 chunk +1 line, -0 lines 1 comment Download
A src/plugin/ATL_Deprecate.h View 1 chunk +143 lines, -0 lines 0 comments Download
M src/plugin/PluginStdAfx.h View 1 chunk +1 line, -5 lines 1 comment Download

Messages

Total messages: 4
Eric
http://codereview.adblockplus.org/5765952465534976/diff/5629499534213120/src/plugin/PluginStdAfx.h File src/plugin/PluginStdAfx.h (left): http://codereview.adblockplus.org/5765952465534976/diff/5629499534213120/src/plugin/PluginStdAfx.h#oldcode28 src/plugin/PluginStdAfx.h:28: #include <comutil.h> <comutil.h> is unused.
July 24, 2014, 2:10 p.m. (2014-07-24 14:10:10 UTC) #1
sergei
LGTM
July 24, 2014, 2:37 p.m. (2014-07-24 14:37:24 UTC) #2
Oleksandr
http://codereview.adblockplus.org/5765952465534976/diff/5629499534213120/adblockplus.gyp File adblockplus.gyp (right): http://codereview.adblockplus.org/5765952465534976/diff/5629499534213120/adblockplus.gyp#newcode87 adblockplus.gyp:87: 'src/plugin/ATL_Deprecate.h', There are no .h files here yet. I ...
July 25, 2014, 8:30 a.m. (2014-07-25 08:30:27 UTC) #3
Oleksandr
July 25, 2014, 9:44 p.m. (2014-07-25 21:44:00 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld