Unified Diff: notification.html
Issue 5767063142400000:
notification fixes (Closed)
Patch Set: removed import of ext/background.js from notification.html
Created March 4, 2014, 4:19 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« chrome/ext/background.js ('k')
|
notification.js » ('j')
|
notification.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: notification.html |
| =================================================================== |
| --- a/notification.html |
| +++ b/notification.html |
| @@ -27,7 +27,6 @@ |
| } |
| </style> |
| <script src="ext/common.js"></script> |
|
Thomas Greiner
2014/03/05 13:24:47
We don't need ext/common.js anymore if we remove n
saroyanm
2014/03/05 13:44:28
notification.js also imported in popup.html, so we
Thomas Greiner
2014/03/05 13:51:48
Good point. In that case I'd be in favor of keepin
Sebastian Noack
2014/03/05 14:11:56
Don't we also need ext.windows in order to open a
saroyanm
2014/03/05 14:36:26
In that case maybe we can still import ext/common.
Sebastian Noack
2014/03/05 18:48:15
I would still prefer something like this at the to
|
| - <script src="ext/background.js"></script> |
| <script src="notification.js"></script> |
| </head> |
| <body> |
« no previous file with comments
|
« chrome/ext/background.js ('k')
|
notification.js » ('j')
|
notification.js » ('J')
