Issue 2053 - Replace Adblock Plus logo on the first-run page

Issue 2053 - Replace Adblock Plus logo on the first-run page

[Thomas Greiner, 2015-02-27 10:51:23]

http://codereview.adblockplus.org/5767210236641280/diff/5629499534213120/skin...
File skin/firstRun.css (right):

http://codereview.adblockplus.org/5767210236641280/diff/5629499534213120/skin...
skin/firstRun.css:158: background-image: url(abp-icon-big.png);
For consistency's sake and to avoid duplication I'd suggest renaming the image
file to "abp-128.png".

Note that the issue description does not specify whether to use the name of the
old or of the new image.

[Wladimir Palant, 2015-02-27 16:17:25]

http://codereview.adblockplus.org/5767210236641280/diff/5629499534213120/skin...
File skin/firstRun.css (right):

http://codereview.adblockplus.org/5767210236641280/diff/5629499534213120/skin...
skin/firstRun.css:158: background-image: url(abp-icon-big.png);
On 2015/02/27 10:51:23, Thomas Greiner wrote:
> For consistency's sake and to avoid duplication I'd suggest renaming the image
> file to "abp-128.png".

I considered that already. However, avoiding duplication isn't as simple as it
sounds - it would require moving abp-128.png to a new location in Chrome, so
that it can be accessed under the same relative URL both in Firefox and Chrome
(and this repository). And that would break consistency there.

So until we come up with a different structure for the adblockpluschrome
repository, I'd rather keep the file name to make sure the dependency update
isn't unnecessarily complicated.

> Note that the issue description does not specify whether to use the name of
the
> old or of the new image.

That's intentional, the purpose of the issue description isn't documenting
implementation details.

[Thomas Greiner, 2015-02-27 16:22:49]

LGTM

http://codereview.adblockplus.org/5767210236641280/diff/5629499534213120/skin...
File skin/firstRun.css (right):

http://codereview.adblockplus.org/5767210236641280/diff/5629499534213120/skin...
skin/firstRun.css:158: background-image: url(abp-icon-big.png);
On 2015/02/27 16:17:25, Wladimir Palant wrote:
> On 2015/02/27 10:51:23, Thomas Greiner wrote:
> > For consistency's sake and to avoid duplication I'd suggest renaming the
image
> > file to "abp-128.png".
> 
> I considered that already. However, avoiding duplication isn't as simple as it
> sounds - it would require moving abp-128.png to a new location in Chrome, so
> that it can be accessed under the same relative URL both in Firefox and Chrome
> (and this repository). And that would break consistency there.
> 
> So until we come up with a different structure for the adblockpluschrome
> repository, I'd rather keep the file name to make sure the dependency update
> isn't unnecessarily complicated.

Ok, I'm fine with addressing this later on.