Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: ext/background.js

Issue 5817039037923328: Issue 1813 - Implement ext.showOptions() in Firefox (Closed)
Patch Set: Created Jan. 15, 2015, 1:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 { 88 {
89 return this._map.has(page._sender); 89 return this._map.has(page._sender);
90 }, 90 },
91 91
92 delete: function(page) 92 delete: function(page)
93 { 93 {
94 this._map.delete(page._sender); 94 this._map.delete(page._sender);
95 } 95 }
96 }; 96 };
97 exports.PageMap = PageMap; 97 exports.PageMap = PageMap;
98
99 exports.showOptions = function(callback)
100 {
101 if (typeof callback != "undefined")
102 Cu.reportError("Unsupported callback parameter passed to ext.showOptions");
Sebastian Noack 2015/01/15 13:04:57 Just omit the callback argument? The rest of the a
Wladimir Palant 2015/01/15 14:47:34 It was meant mostly as a reminder, this will likel
103
104 require("ui").UI.openFiltersDialog();
105 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld