Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5817039037923328: Issue 1813 - Implement ext.showOptions() in Firefox (Closed)

Created:
Jan. 15, 2015, 1:02 p.m. by Wladimir Palant
Modified:
Jan. 15, 2015, 6:25 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 1813 - Implement ext.showOptions() in Firefox

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed callback parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ext/background.js View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Jan. 15, 2015, 1:02 p.m. (2015-01-15 13:02:18 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5817039037923328/diff/5629499534213120/ext/background.js File ext/background.js (right): http://codereview.adblockplus.org/5817039037923328/diff/5629499534213120/ext/background.js#newcode102 ext/background.js:102: Cu.reportError("Unsupported callback parameter passed to ext.showOptions"); Just omit the ...
Jan. 15, 2015, 1:04 p.m. (2015-01-15 13:04:57 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5817039037923328/diff/5629499534213120/ext/background.js File ext/background.js (right): http://codereview.adblockplus.org/5817039037923328/diff/5629499534213120/ext/background.js#newcode102 ext/background.js:102: Cu.reportError("Unsupported callback parameter passed to ext.showOptions"); On 2015/01/15 13:04:57, ...
Jan. 15, 2015, 2:47 p.m. (2015-01-15 14:47:33 UTC) #3
Sebastian Noack
Jan. 15, 2015, 2:54 p.m. (2015-01-15 14:54:13 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld