Added high resolution icons for Retina displays

see https://issues.adblockplus.org/ticket/4

[Wladimir Palant, 2014-04-02 16:37:24]

http://codereview.adblockplus.org/5838171610808320/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/5838171610808320/diff/5629499534213120/chro...
chrome/ext/background.js:213: paths[size] = path.replace(/((?:.*\/)*.+?\b)/,
'$1-' + size);
This is rather non-obvious behavior. It should be made obvious, e.g. by
specifying "abp-$size.png" as file path. It will also allow you to use a simple
replacement rather than this complex regexp. I'm aware that the icon has to be
called abp-16@2x.png in Safari then but IMHO that's fine.

[Sebastian Noack, 2014-04-02 17:02:08]

http://codereview.adblockplus.org/5838171610808320/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/5838171610808320/diff/5629499534213120/chro...
chrome/ext/background.js:213: paths[size] = path.replace(/((?:.*\/)*.+?\b)/,
'$1-' + size);
On 2014/04/02 16:37:24, Wladimir Palant wrote:
> This is rather non-obvious behavior. It should be made obvious, e.g. by
> specifying "abp-$size.png" as file path. It will also allow you to use a
simple
> replacement rather than this complex regexp. I'm aware that the icon has to be
> called mailto:abp-16@2x.png in Safari then but IMHO that's fine.

But then we would need something like |path.replace(/-?$size/, "")| for Safari
to remove the size placeholder and its leading dash.

Note that the icon on Safari is now just called abp[@2x].png (without size
infix). So I was able remove the code switching the size of the icon, dependent
on the browser. And I also found it non-obvious to have images which are twice
as large as their size infix suggests.

[Wladimir Palant, 2014-04-03 05:43:40]

http://codereview.adblockplus.org/5838171610808320/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/5838171610808320/diff/5629499534213120/chro...
chrome/ext/background.js:213: paths[size] = path.replace(/((?:.*\/)*.+?\b)/,
'$1-' + size);
On 2014/04/02 17:02:08, Sebastian Noack wrote:
> But then we would need something like |path.replace(/-?$size/, "")| for Safari
> to remove the size placeholder and its leading dash.

No, path.replace("$size", "16") should do, the icon should still be called
abp-16.png. As I said, abp-16@2x.png isn't optimal but the "@2x" part still
makes it somewhat obvious.

[Sebastian Noack, 2014-04-03 11:42:26]

http://codereview.adblockplus.org/5838171610808320/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/5838171610808320/diff/5629499534213120/chro...
chrome/ext/background.js:213: paths[size] = path.replace(/((?:.*\/)*.+?\b)/,
'$1-' + size);
On 2014/04/03 05:43:40, Wladimir Palant wrote:
> On 2014/04/02 17:02:08, Sebastian Noack wrote:
> > But then we would need something like |path.replace(/-?$size/, "")| for
Safari
> > to remove the size placeholder and its leading dash.
> 
> No, path.replace("$size", "16") should do, the icon should still be called
> abp-16.png. As I said, mailto:abp-16@2x.png isn't optimal but the "@2x" part
still
> makes it somewhat obvious.

I somewhat agree. Here you go.

[Wladimir Palant, 2014-04-03 11:47:06]

LGTM