Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5852174588313600: Issue 2602 - Don't use shadow DOM on mail.google.com, fixing an issue with the feedback form there (Closed)

Created:
June 3, 2015, 9:29 a.m. by Sebastian Noack
Modified:
June 3, 2015, 3:43 p.m.
Reviewers:
Thomas Greiner
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2602 - Don't use shadow DOM on mail.google.com, fixing an issue with the feedback form there

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wrap line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M include.preload.js View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
June 3, 2015, 9:48 a.m. (2015-06-03 09:48:05 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/5852174588313600/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5852174588313600/diff/5629499534213120/include.preload.js#newcode201 include.preload.js:201: if ("createShadowRoot" in document.documentElement && document.domain != "docs.google.com" Let's ...
June 3, 2015, 2:24 p.m. (2015-06-03 14:24:25 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5852174588313600/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/5852174588313600/diff/5629499534213120/include.preload.js#newcode201 include.preload.js:201: if ("createShadowRoot" in document.documentElement && document.domain != "docs.google.com" On ...
June 3, 2015, 3:33 p.m. (2015-06-03 15:33:06 UTC) #3
Thomas Greiner
June 3, 2015, 3:34 p.m. (2015-06-03 15:34:21 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld