Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(247)

Issue 5855687158530048: Issue 348 - Fixed bug when updating badge in response to preference change (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by Sebastian Noack
Modified:
5 years, 5 months ago
Visibility:
Public.

Description

The code that updates the badge for each page when the show_statsinicon preference changes, is currently broken and throws an exception. That is because the code assumes that the callback passed to ext.pages.query() is called for each page. But instead it is called only once with an array of pages.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M lib/stats.js View 1 chunk +16 lines, -10 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
5 years, 6 months ago (2014-04-18 20:29:47 UTC) #1
Wladimir Palant
5 years, 5 months ago (2014-04-24 09:32:51 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5