Issue 5855687158530048: Issue 348 - Fixed bug when updating badge in response to preference change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5855687158530048: Issue 348 - Fixed bug when updating badge in response to preference change (Closed)

Created:
April 18, 2014, 8:21 p.m. by Sebastian Noack

Modified:
April 24, 2014, 9:36 a.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

The code that updates the badge for each page when the show_statsinicon preference changes, is currently broken and throws an exception. That is because the code assumes that the callback passed to ext.pages.query() is called for each page. But instead it is called only once with an array of pages.

Patch Set 1 #

Created: April 18, 2014, 8:21 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	lib/stats.js	View		1 chunk	+16 lines, -10 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages