Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5901398378020864: Stats processing: don`t count hidden fields for the maximal filter nesting level (Closed)

Created:
Jan. 27, 2014, 1:05 p.m. by Wladimir Palant
Modified:
Jan. 30, 2014, 12:11 p.m.
Reviewers:
Sebastian Noack
CC:
Felix Dahlke
Visibility:
Public.

Description

Stats processing: don`t count hidden fields for the maximal filter nesting level

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M sitescripts/stats/bin/logprocessor.py View 1 chunk +11 lines, -1 line 1 comment Download

Messages

Total messages: 2
Wladimir Palant
Jan. 27, 2014, 1:05 p.m. (2014-01-27 13:05:40 UTC) #1
Sebastian Noack
Jan. 28, 2014, 1:30 p.m. (2014-01-28 13:30:14 UTC) #2
LGTM, with the nit addressed.

http://codereview.adblockplus.org/5901398378020864/diff/5629499534213120/site...
File sitescripts/stats/bin/logprocessor.py (right):

http://codereview.adblockplus.org/5901398378020864/diff/5629499534213120/site...
sitescripts/stats/bin/logprocessor.py:437: return "hidden" not in field or not
field["hidden"]
In Python you would do that preferable with one lookup:

  not field.get("hidden", False)

Powered by Google App Engine
This is Rietveld