Issue 5911246494760960: Issue 2640 - Added missing notifications_ignoredcategories preference

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5911246494760960: Issue 2640 - Added missing notifications_ignoredcategories preference (Closed)

Created:
June 4, 2015, 8:59 p.m. by Sebastian Noack

Modified:
June 4, 2015, 10:03 p.m.

Reviewers:
Thomas Greiner, Wladimir Palant

Visibility:
Public.

Description

Issue 2640 - Added missing notifications_ignoredcategories preference

Patch Set 1 : #

Total comments: 2

Created: June 4, 2015, 9:06 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	lib/prefs.js	View		1 chunk	+7 lines, -0 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Thomas Greiner

http://codereview.adblockplus.org/5911246494760960/diff/5741031244955648/lib/prefs.js File lib/prefs.js (right): http://codereview.adblockplus.org/5911246494760960/diff/5741031244955648/lib/prefs.js#newcode150 lib/prefs.js:150: defaults.notifications_ignoredcategories = []; #2192 also introduced the "notifications_showui" boolean ...

June 4, 2015, 9:44 p.m. (2015-06-04 21:44:31 UTC) #3

Sebastian Noack

June 4, 2015, 9:46 p.m. (2015-06-04 21:46:30 UTC) #4

Thomas Greiner

June 4, 2015, 10:03 p.m. (2015-06-04 22:03:48 UTC) #5

On 2015/06/04 21:46:30, Sebastian Noack wrote:
>
http://codereview.adblockplus.org/5911246494760960/diff/5741031244955648/lib/...
> File lib/prefs.js (right):
> 
>
http://codereview.adblockplus.org/5911246494760960/diff/5741031244955648/lib/...
> lib/prefs.js:150: defaults.notifications_ignoredcategories = [];
> On 2015/06/04 21:44:31, Thomas Greiner wrote:
> > #2192 also introduced the "notifications_showui" boolean preference so I'd
> > suggest also adding that one with the default value being `false`.
> 
> Argh, I just pushed the change this very moment. But anyway, It think that
> option can be added we actually implement the UI for the opt-out, as its
> currently unused.

Yep, as long as we're not calling `Notification.toggleIgnoreCategory` in
Platform we're fine. I've planned to add that preference as part of #2195
anyway.

Expand All Messages | Collapse All Messages