Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(355)

Issue 5920587679531008: Issue 1946 - Include form-mail sender address in message content (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by mathias
Modified:
4 years, 7 months ago
CC:
Fred
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/1946 for more information --

Patch Set 1 #

Total comments: 3

Patch Set 2 : Issue 1946 - Use datetime.now().strftime() instead of strftime() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sitescripts/formmail/template/eyeo.mail View 1 1 chunk +1 line, -1 line 0 comments Download
M sitescripts/formmail/web/formmail.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
mathias
4 years, 7 months ago (2015-04-17 01:57:34 UTC) #1
mathias
http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/sitescripts/formmail/web/formmail.py File sitescripts/formmail/web/formmail.py (right): http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/sitescripts/formmail/web/formmail.py#newcode39 sitescripts/formmail/web/formmail.py:39: That accidental white-space is removed already.
4 years, 7 months ago (2015-04-17 02:00:06 UTC) #2
Sebastian Noack
LGTM
4 years, 7 months ago (2015-04-17 10:08:52 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/sitescripts/formmail/web/formmail.py File sitescripts/formmail/web/formmail.py (right): http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/sitescripts/formmail/web/formmail.py#newcode55 sitescripts/formmail/web/formmail.py:55: params['strftime'] = time.strftime This seems wrong - strftime isn't ...
4 years, 7 months ago (2015-04-17 13:46:32 UTC) #4
mathias
4 years, 7 months ago (2015-04-17 14:31:52 UTC) #5
mathias
http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/sitescripts/formmail/web/formmail.py File sitescripts/formmail/web/formmail.py (right): http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/sitescripts/formmail/web/formmail.py#newcode55 sitescripts/formmail/web/formmail.py:55: params['strftime'] = time.strftime On 2015/04/17 13:46:32, Wladimir Palant wrote: ...
4 years, 7 months ago (2015-04-17 14:32:55 UTC) #6
Wladimir Palant
4 years, 7 months ago (2015-04-17 15:03:23 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5