Issue 1946 - Include form-mail sender address in message content

See https://issues.adblockplus.org/ticket/1946 for more information --

[mathias, 2015-04-17 02:00:06]

http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/site...
File sitescripts/formmail/web/formmail.py (right):

http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/site...
sitescripts/formmail/web/formmail.py:39: 
That accidental white-space is removed already.

[Sebastian Noack, 2015-04-17 10:08:52]

LGTM

[Wladimir Palant, 2015-04-17 13:46:32]

http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/site...
File sitescripts/formmail/web/formmail.py (right):

http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/site...
sitescripts/formmail/web/formmail.py:55: params['strftime'] = time.strftime
This seems wrong - strftime isn't a parameter, it's a filter transforming a
time. The actual parameter here is the time when the message was received, and
with this approach the template implicitly sets it to "whenever the template was
rendered."

It should be better to pass in datetime.now() as parameter - it will have an
strftime() method that the template can call.

[mathias, 2015-04-17 14:32:55]

http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/site...
File sitescripts/formmail/web/formmail.py (right):

http://codereview.adblockplus.org/5920587679531008/diff/5629499534213120/site...
sitescripts/formmail/web/formmail.py:55: params['strftime'] = time.strftime
On 2015/04/17 13:46:32, Wladimir Palant wrote:
> This seems wrong - strftime isn't a parameter, it's a filter transforming a
> time. The actual parameter here is the time when the message was received, and
> with this approach the template implicitly sets it to "whenever the template
was
> rendered."
> 
> It should be better to pass in datetime.now() as parameter - it will have an
> strftime() method that the template can call.

Done.

[Wladimir Palant, 2015-04-17 15:03:23]

LGTM