Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5924532154007552: Issue 1149 - Fix the installer version (Closed)

Created:
Aug. 12, 2014, 1:32 a.m. by Oleksandr
Modified:
Aug. 12, 2014, 10:14 a.m.
Reviewers:
Felix Dahlke, Eric
Visibility:
Public.

Description

Installer project files need to be re-created every time you make a build.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use revision number for devbuilds and IEPLUGIN_VERSION otherwise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M build_release.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M installer/createsolutions.bat View 1 1 chunk +5 lines, -3 lines 0 comments Download
M installer/installer.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Oleksandr
Aug. 12, 2014, 1:35 a.m. (2014-08-12 01:35:56 UTC) #1
Eric
LGTM. There's always been a tension about "build for development" vs. "build for release". This ...
Aug. 12, 2014, 2:11 a.m. (2014-08-12 02:11:13 UTC) #2
Felix Dahlke
LGTM, for now Can we create a follow-up for this? I think it'd be most ...
Aug. 12, 2014, 7:49 a.m. (2014-08-12 07:49:58 UTC) #3
Oleksandr
Aug. 12, 2014, 9:27 a.m. (2014-08-12 09:27:07 UTC) #4
Felix Dahlke
Aug. 12, 2014, 9:30 a.m. (2014-08-12 09:30:03 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld