Issue 2108 - hreflang ads extra flag after migration from Anwiki to CMS

Related ticket:
https://issues.adblockplus.org/ticket/2108

[saroyanm, 2015-04-08 12:26:23]

Wladimir I've made a comment under the ticket regarding implementation, please
let me know if you are Okey with it, so I'll also update the ticket description
accordingly.

[Wladimir Palant, 2015-04-08 12:29:11]

http://codereview.adblockplus.org/5932042894180352/diff/5629499534213120/anwi...
File anwiki/_override-static/global/global/css/main.css (right):

http://codereview.adblockplus.org/5932042894180352/diff/5629499534213120/anwi...
anwiki/_override-static/global/global/css/main.css:223:
a[hreflang="en"]:not(:lang(en)):not(#language-selector a):after
While it will work for this particular flag, wouldn't it make sense to limit
this selector to the content area altogether? Meaning something like:

#content a[hreflang="de"]:not(:lang(de)):after

[saroyanm, 2015-04-08 12:32:50]

http://codereview.adblockplus.org/5932042894180352/diff/5629499534213120/anwi...
File anwiki/_override-static/global/global/css/main.css (right):

http://codereview.adblockplus.org/5932042894180352/diff/5629499534213120/anwi...
anwiki/_override-static/global/global/css/main.css:223:
a[hreflang="en"]:not(:lang(en)):not(#language-selector a):after
On 2015/04/08 12:29:12, Wladimir Palant wrote:
> While it will work for this particular flag, wouldn't it make sense to limit
> this selector to the content area altogether? Meaning something like:
> 
> #content a[hreflang="de"]:not(:lang(de)):after

Unfortunately not, because we show flag also for header menu items (ex.: About,
Features, contribution) if the page is not translated for the current language.

[Wladimir Palant, 2015-04-08 12:37:01]

http://codereview.adblockplus.org/5932042894180352/diff/5629499534213120/anwi...
File anwiki/_override-static/global/global/css/main.css (right):

http://codereview.adblockplus.org/5932042894180352/diff/5629499534213120/anwi...
anwiki/_override-static/global/global/css/main.css:223:
a[hreflang="en"]:not(:lang(en)):not(#language-selector a):after
On 2015/04/08 12:32:50, saroyanm wrote:
> Unfortunately not, because we show flag also for header menu items (ex.:
About,
> Features, contribution) if the page is not translated for the current
language.

I see, too bad. However, per specification :not() only allows simple selectors -
meaning that :not(#language-selector a) isn't valid, even though it might work
in some browsers. How about:

#language-selector a:after
{
  display: none;
}

[saroyanm, 2015-04-08 12:42:20]

http://codereview.adblockplus.org/5932042894180352/diff/5629499534213120/anwi...
File anwiki/_override-static/global/global/css/main.css (right):

http://codereview.adblockplus.org/5932042894180352/diff/5629499534213120/anwi...
anwiki/_override-static/global/global/css/main.css:223:
a[hreflang="en"]:not(:lang(en)):not(#language-selector a):after
On 2015/04/08 12:37:02, Wladimir Palant wrote:
> On 2015/04/08 12:32:50, saroyanm wrote:
> > Unfortunately not, because we show flag also for header menu items (ex.:
> About,
> > Features, contribution) if the page is not translated for the current
> language.
> 
> I see, too bad. However, per specification :not() only allows simple selectors
-
> meaning that :not(#language-selector a) isn't valid, even though it might work
> in some browsers. How about:
> 
> #language-selector a:after
> {
>   display: none;
> }

Yes definitely, good point.
Updated.

[Wladimir Palant, 2015-04-08 13:57:45]

LGTM