Issue 5933140862304256: Issue 1655 - Add "short_name" to manifest.json for Chrome and Opera

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5933140862304256: Issue 1655 - Add "short_name" to manifest.json for Chrome and Opera (Closed)

Created:
Dec. 3, 2014, 3:35 p.m. by Sebastian Noack

Modified:
Dec. 3, 2014, 4:45 p.m.

Reviewers:
Thomas Greiner

CC:
Wladimir Palant, kzar

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: Dec. 3, 2014, 3:35 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	manifest.json.tmpl	View		1 chunk	+1 line, -0 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Thomas Greiner

http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/manifest.json.tmpl File manifest.json.tmpl (right): http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/manifest.json.tmpl#newcode13 manifest.json.tmpl:13: "short_name": "__MSG_name__", Since this field is limited to 12 ...

Dec. 3, 2014, 3:47 p.m. (2014-12-03 15:47:21 UTC) #2

Sebastian Noack

Dec. 3, 2014, 3:57 p.m. (2014-12-03 15:57:44 UTC) #3

Thomas Greiner

Dec. 3, 2014, 4:19 p.m. (2014-12-03 16:19:38 UTC) #4

Please note that according to
https://code.google.com/p/chromium/issues/detail?id=317165 "short_name" has only
been supported since Chrome 31 but it doesn't appear to cause any problems
whatsoever in older versions.

Therefore LGTM

http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/mani...
File manifest.json.tmpl (right):

http://codereview.adblockplus.org/5933140862304256/diff/5629499534213120/mani...
manifest.json.tmpl:13: "short_name": "__MSG_name__",
On 2014/12/03 15:57:44, Sebastian Noack wrote:
> Also note that it is truncated in
> packagerChrome.py anyway in case it has more than 12 chars.

Ok, that's fine then.

Expand All Messages | Collapse All Messages