Issue 5944359652425728: Issue 2109 - Drop assumption that metadata format depends on platform

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5944359652425728: Issue 2109 - Drop assumption that metadata format depends on platform (Closed)

Created:
March 9, 2015, 7:37 p.m. by Wladimir Palant

Modified:
March 26, 2015, 9:10 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue 2109 - Drop assumption that metadata format depends on platform

Patch Set 1 #

Created: March 9, 2015, 7:37 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -11 lines)			Patch
	M	build.py	View		1 chunk	+16 lines, -11 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sebastian Noack

I guess I'll review this when I have seen the other patches, since this change ...

March 9, 2015, 8:04 p.m. (2015-03-09 20:04:15 UTC) #2

Wladimir Palant

On 2015/03/09 20:04:15, Sebastian Noack wrote: > I guess I'll review this when I have ...

March 10, 2015, 7:47 a.m. (2015-03-10 07:47:17 UTC) #3

Sebastian Noack

March 12, 2015, 9:54 a.m. (2015-03-12 09:54:31 UTC) #4

On 2015/03/10 07:47:17, Wladimir Palant wrote:
> On 2015/03/09 20:04:15, Sebastian Noack wrote:
> > I guess I'll review this when I have seen the other patches, since this
change
> > alone would just break Android and IE.
> 
> Why that? We don't currently have any logic for Android or IE but the idea was
> that it could be added to packager.readMetadata() once we need it (even
assuming
> we decide not going with a regular metadata file there).

You are right, that code seems to be only used for Firefox, Chrome, Opera and
Safari. Should be fine then. LGTM.

Expand All Messages | Collapse All Messages