Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5947799854120960: Issue 1651 - Added proper promo image for homepage metadata (Closed)

Created:
Dec. 11, 2014, 3:26 p.m. by Thomas Greiner
Modified:
Dec. 12, 2014, 1:02 p.m.
Reviewers:
saroyanm
CC:
Felix Dahlke
Visibility:
Public.

Description

This review consists of two parts: 1) The image which will be added to the anwiki repository under /_override-static/global/global/img/adblockplus_promo.png 2) The changes to the adblockplus.org homepage <head> content

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A adblockplus_promo.png View Binary file 0 comments Download
M head.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Thomas Greiner
Dec. 11, 2014, 3:31 p.m. (2014-12-11 15:31:07 UTC) #1
saroyanm
Dec. 12, 2014, 6:14 a.m. (2014-12-12 06:14:11 UTC) #2
On 2014/12/11 15:31:07, Thomas Greiner wrote:

LGTM - but we still should keep in mind that while debugger suggest 200x200px
minimum image size, the other documentation suggests to use 1200x630px.

Powered by Google App Engine
This is Rietveld