Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5960705870135296: Fixed genrated filter rules for elements with CSS class (Closed)

Created:
Jan. 24, 2014, 2:40 p.m. by Sebastian Noack
Modified:
Jan. 30, 2014, 1:02 p.m.
CC:
Thomas Greiner
Visibility:
Public.

Description

When choosing an element to block, via "Block Element" from the bubble, I noted following two issues: * Characters like the comma (see https://adblockplus.org/forum/viewtopic.php?f=18&t=20723) aren't escaped (unlike with the Element Hiding Helper on Firefox). * When the element has multiple css classes, one rule for each class is generated instead of a rule that matches both (unlike with the Element Hiding Helper on Firefox).

Patch Set 1 #

Patch Set 2 : Removed console.log() and simplified regex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M include.postload.js View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
Jan. 24, 2014, 2:46 p.m. (2014-01-24 14:46:11 UTC) #1
Wladimir Palant
Jan. 30, 2014, 12:30 p.m. (2014-01-30 12:30:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld