Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5999015493632000: Issue 2541 - Suppress error on Opera when calling chrome.storage.managed.get() (Closed)

Created:
May 18, 2015, 4:51 p.m. by Sebastian Noack
Modified:
May 19, 2015, 4:41 p.m.
Reviewers:
Thomas Greiner
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2541 - Suppress error on Opera when calling chrome.storage.managed.get()

Patch Set 1 #

Total comments: 3

Patch Set 2 : Made comment more verbose #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M lib/prefs.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
May 18, 2015, 4:52 p.m. (2015-05-18 16:52:28 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/5999015493632000/diff/5629499534213120/lib/prefs.js File lib/prefs.js (right): http://codereview.adblockplus.org/5999015493632000/diff/5629499534213120/lib/prefs.js#newcode286 lib/prefs.js:286: // Shut up Opera ;P I literally had to ...
May 19, 2015, 9:47 a.m. (2015-05-19 09:47:39 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5999015493632000/diff/5629499534213120/lib/prefs.js File lib/prefs.js (right): http://codereview.adblockplus.org/5999015493632000/diff/5629499534213120/lib/prefs.js#newcode286 lib/prefs.js:286: // Shut up Opera ;P On 2015/05/19 09:47:39, Thomas ...
May 19, 2015, 4:09 p.m. (2015-05-19 16:09:01 UTC) #3
Thomas Greiner
May 19, 2015, 4:39 p.m. (2015-05-19 16:39:53 UTC) #4
LGTM

http://codereview.adblockplus.org/5999015493632000/diff/5629499534213120/lib/...
File lib/prefs.js (right):

http://codereview.adblockplus.org/5999015493632000/diff/5629499534213120/lib/...
lib/prefs.js:286: // Shut up Opera ;P
On 2015/05/19 16:09:01, Sebastian Noack wrote:
> On 2015/05/19 09:47:39, Thomas Greiner wrote:
> > I literally had to LOL when I read this. :D
> > 
> > Still, a more descriptive explanation might be appropriate here since this
is
> > quite unexpected behavior.
> 
> I found it quite descriptive, as making Opera shut up, is what that line does.
> But fair enough, here you have a more boring version of it. ;P

Thanks a lot!

Powered by Google App Engine
This is Rietveld