Side by Side Diff: build.py
Issue 6018170477346816:
1588 - Integrate ensure_dependencies.py with the adblockplus repository (Closed)
Patch Set: 1588 - Integrate ensure_dependencies.py with the adblockplus repository
Created Dec. 17, 2014, 4:17 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« .hgsubstate ('k')
|
dependencies » ('j')
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # coding: utf-8 | 2 # coding: utf-8 |
| 3 | 3 |
| 4 import os, sys, subprocess | 4 import os, sys, subprocess |
| 5 | 5 |
| 6 DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies .py") | |
| 7 | |
| 8 if os.path.isfile(DEPENDENCY_SCRIPT): | |
| 9 try: | |
| 10 subprocess.check_call(["python", DEPENDENCY_SCRIPT]) | |
| 11 except subprocess.CalledProcessError as e: | |
| 12 print >>sys.stderr, str(e) | |
|
Wladimir Palant
2014/12/17 16:22:18
Not addressed: print e rather than str(e)?
| |
| 13 print >>sys.stderr, "Failed to ensure dependencies being up-to-date!" | |
| 14 | |
|
Wladimir Palant
2014/12/17 16:22:18
Nit: The indentation is wrong, we use two spaces f
| |
| 6 import buildtools.build | 15 import buildtools.build |
| 7 buildtools.build.processArgs('.', sys.argv) | 16 buildtools.build.processArgs('.', sys.argv) |
| OLD | NEW |
« no previous file with comments
|
« .hgsubstate ('k')
|
dependencies » ('j')
|
no next file with comments »
