1588 - Integrate ensure_dependencies.py with the adblockplus repository

This is the first of many changes on different repositories, see ticket 1364 for more info, since all the changes are the same, the review is needed just in one in order to implement in the others

[mathias, 2014-11-21 15:19:05]

Actually, I doubt that we want the `setup.py` script to trigger
`ensure_dependencies.py` whenever it is invoked. That may be a pain for
developers who actually try to run a build or test on a repository with
explicitly modified resources in the sub-modules. So, maybe a verbose paragraph
in the README is a better solution here?

By the way; as discussed yesterday in IRC, many people obviously prefer
performing each step manually. In addition, we've already had some pain with
e.g. the `Vagrantfile` in the `infrastructure` repository invoking the Python
script all the time..

http://codereview.adblockplus.org/6018170477346816/diff/5629499534213120/buil...
File build.py (right):

http://codereview.adblockplus.org/6018170477346816/diff/5629499534213120/buil...
build.py:12: print "Failed to ensure dependencies being up-to-date!"
Please print error messages and similar to `sys.stderr`.

[Wladimir Palant, 2014-11-24 12:40:45]

Is there a reason why this is being approached now? The idea was to address
https://issues.adblockplus.org/ticket/1364 first.

[paco, 2014-11-25 10:08:17]

On 2014/11/24 12:40:45, Wladimir Palant wrote:
> Is there a reason why this is being approached now? The idea was to address
> https://issues.adblockplus.org/ticket/1364 first.

It's the same change in this repo than in the others, so after this review we
can push the changes in the others first and then in this one, I just started
first with this and then I realized the other ticket.

[Wladimir Palant, 2014-12-17 14:29:31]

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/buil...
File build.py (right):

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/buil...
build.py:6: DEPENDECY_SCRIPT = os.path.join(os.getcwd(),
"ensure_dependencies.py")
1) Nit: DEPENDENCY_SCRIPT please.
2) Don't use current work directory, this should be os.path.dirname(__file__).

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/buil...
build.py:9: subprocess.check_call(["python", DEPENDECY_SCRIPT])
Only call this if the script actually exists please - this file should be the
same everywhere, and we don't want any warnings if there are no dependencies.

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/buil...
build.py:11: print >>sys.stderr, str(e)+'\n'
print will automatically add a newline, no need to do this. Also, e doesn't need
to be converted to string explicitly:

  print >>sys.stderr, e

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/buil...
build.py:12: print >>sys.stderr,"Failed to ensure dependencies being
up-to-date!"+'\n'
Style nit: space after comma please.

Newline is unnecessary here as well.

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/depe...
File dependencies (right):

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/depe...
dependencies:1: _root = hg:https://hg.adblockplus.org/
git:https://github.com/adblockplus/
Please enable self-update:

  _self = buildtools/ensure_dependencies.py

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/depe...
dependencies:2: buildtools = buildtools hg:f9f664d8ee05 git:2efd35c
You are going to update the dependency on buildtools for a number of extensions,
please verify that the build doesn't change as a result.

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/ensu...
File ensure_dependencies.py (right):

http://codereview.adblockplus.org/6018170477346816/diff/5757334940811264/ensu...
ensure_dependencies.py:285: resolve_deps(repo)
I'm assuming that this is the current ensure_dependencies.py script from
buildtools repository without any changes, not reviewing it.

[Wladimir Palant, 2014-12-17 16:22:18]

http://codereview.adblockplus.org/6018170477346816/diff/5738600293466112/buil...
File build.py (right):

http://codereview.adblockplus.org/6018170477346816/diff/5738600293466112/buil...
build.py:12: print >>sys.stderr, str(e)
Not addressed: print e rather than str(e)?

http://codereview.adblockplus.org/6018170477346816/diff/5738600293466112/buil...
build.py:14: 
Nit: The indentation is wrong, we use two spaces for indentation. Also, please
remove the trailing whitespace on the line above.

[Wladimir Palant, 2014-12-18 21:02:47]

LGTM

[mathias, 2015-01-05 10:18:29]

LGTM

[Wladimir Palant, 2015-01-13 16:29:02]

Could you rebase your change please, so that it can be pushed?

* The buildtools dependency should be current
(hg:be85e6094718f638dc5d870c8350478e58c179b0
git:021b78c35e9e19a81f6a3eb1449d868b4cfb828a), two Git-related issues have been
fixed there.
* There is a new adblockplusui dependency.
* ensure_dependencies.py itself has to be updated.

[Wladimir Palant, 2015-01-13 16:47:23]

LGTM again, I'll push that change.

[01687286395a, 2017-10-12 15:28:18]

01687286395

[01687286395a, 2017-10-12 15:28:22]

01687286395