build.py - Issue 6018170477346816: 1588 - Integrate ensure_dependencies.py with the adblockplus repository

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: build.py

Issue 6018170477346816: 1588 - Integrate ensure_dependencies.py with the adblockplus repository (Closed)

Left Patch Set: 1588 - Integrate ensure_dependencies.py with the adblockplus repository Created Dec. 17, 2014, 4:17 p.m.

Right Patch Set: '1588 - Integrate ensure_dependencies.py with the adblockplus repository' Created Jan. 13, 2015, 4:44 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # coding: utf-8	2 # coding: utf-8

3	3

4 import os, sys, subprocess	4 import os, sys, subprocess

5	5

6 DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies .py")	6 DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies .py")

7	7

8 if os.path.isfile(DEPENDENCY_SCRIPT):	8 if os.path.isfile(DEPENDENCY_SCRIPT):

9 try:	9 try:

10 subprocess.check_call(["python", DEPENDENCY_SCRIPT])	10 subprocess.check_call(["python", DEPENDENCY_SCRIPT])

11 except subprocess.CalledProcessError as e:	11 except subprocess.CalledProcessError as e:

12 print >>sys.stderr, str(e)	12 print >>sys.stderr, e
Wladimir Palant 2014/12/17 16:22:18 Not addressed: print e rather than str(e)? Not addressed: print e rather than str(e)?
13 print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"	13 print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"

14	14
Wladimir Palant 2014/12/17 16:22:18 Nit: The indentation is wrong, we use two spaces f Nit: The indentation is wrong, we use two spaces for indentation. Also, please remove the trailing whitespace on the line above.
15 import buildtools.build	15 import buildtools.build

16 buildtools.build.processArgs('.', sys.argv)	16 buildtools.build.processArgs('.', sys.argv)

LEFT	RIGHT