Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6041976289886208: Issue 402 - Use a redirector script for downloads, not a direct link (Closed)

Created:
Sept. 9, 2014, 10:41 p.m. by Wladimir Palant
Modified:
Sept. 17, 2014, 8 p.m.
Reviewers:
mathias
Visibility:
Public.

Description

Note that the script in question is being reviewed under http://codereview.adblockplus.org/5747446760079360

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -12 lines) Patch
M modules/updateserver/files/site.conf View 1 chunk +10 lines, -0 lines 0 comments Download
M modules/updateserver/files/sitescripts View 1 1 chunk +12 lines, -12 lines 0 comments Download
M modules/updateserver/manifests/init.pp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Sept. 9, 2014, 10:42 p.m. (2014-09-09 22:42:02 UTC) #1
mathias
LGTM. http://codereview.adblockplus.org/6041976289886208/diff/5629499534213120/modules/updateserver/files/site.conf File modules/updateserver/files/site.conf (right): http://codereview.adblockplus.org/6041976289886208/diff/5629499534213120/modules/updateserver/files/site.conf#newcode4 modules/updateserver/files/site.conf:4: location / Why is the explicit empty location ...
Sept. 15, 2014, 4:15 p.m. (2014-09-15 16:15:55 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6041976289886208/diff/5629499534213120/modules/updateserver/files/site.conf File modules/updateserver/files/site.conf (right): http://codereview.adblockplus.org/6041976289886208/diff/5629499534213120/modules/updateserver/files/site.conf#newcode4 modules/updateserver/files/site.conf:4: location / On 2014/09/15 16:15:56, matze wrote: > Why ...
Sept. 15, 2014, 4:46 p.m. (2014-09-15 16:46:47 UTC) #3
mathias
LGTM, again. http://codereview.adblockplus.org/6041976289886208/diff/5629499534213120/modules/updateserver/files/site.conf File modules/updateserver/files/site.conf (right): http://codereview.adblockplus.org/6041976289886208/diff/5629499534213120/modules/updateserver/files/site.conf#newcode4 modules/updateserver/files/site.conf:4: location / Agreed, leave it as it ...
Sept. 15, 2014, 5:26 p.m. (2014-09-15 17:26:05 UTC) #4
Wladimir Palant
Sept. 17, 2014, 8 p.m. (2014-09-17 20:00:32 UTC) #5
Turned out there was a typo in the settings. Uploaded a new patchset here,
already pushed that change however.

Powered by Google App Engine
This is Rietveld