Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(282)

Issue 6078704820158464: Issue 1553 - Adblock Plus for Yandex Browser (Websites) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by saroyanm
Modified:
4 years, 11 months ago
CC:
Felix Dahlke
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/1553 Infrastructure review: http://codereview.adblockplus.org/5253207810899968/

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M index.html View 1 5 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 6
saroyanm
Thomas can you please have a look when you'll get time.
5 years ago (2014-12-03 13:49:50 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/index.html File index.html (right): http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/index.html#newcode46 index.html:46: <a id="install-yandex-browser" class="install-button" onclick="chrome.webstore.install(); return false;" href="https://clients2.google.com/service/update2/crx?response=redirect&x=id%3Dcfhdojbkjhnklbpkdaibdccddilifddb%26uc">Install for yandex-browser</a> ...
5 years ago (2014-12-05 10:24:49 UTC) #2
Thomas Greiner
One more thing that I just noticed… http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/index.html File index.html (right): http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/index.html#newcode46 index.html:46: <a id="install-yandex-browser" ...
5 years ago (2014-12-05 10:39:00 UTC) #3
saroyanm
http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/index.html File index.html (right): http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/index.html#newcode46 index.html:46: <a id="install-yandex-browser" class="install-button" onclick="chrome.webstore.install(); return false;" href="https://clients2.google.com/service/update2/crx?response=redirect&x=id%3Dcfhdojbkjhnklbpkdaibdccddilifddb%26uc">Install for yandex-browser</a> ...
4 years, 12 months ago (2014-12-07 14:06:01 UTC) #4
Thomas Greiner
LGTM
4 years, 12 months ago (2014-12-08 14:43:38 UTC) #5
Wladimir Palant
4 years, 11 months ago (2014-12-11 22:02:08 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5