Issue 1553 - Adblock Plus for Yandex Browser (Websites)

This review is related to current ticket:
https://issues.adblockplus.org/ticket/1553

Infrastructure review:
http://codereview.adblockplus.org/5253207810899968/

[saroyanm, 2014-12-03 13:49:50]

Thomas can you please have a look when you'll get time.

[Thomas Greiner, 2014-12-05 10:24:49]

http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/inde...
File index.html (right):

http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/inde...
index.html:46: <a id="install-yandex-browser" class="install-button"
onclick="chrome.webstore.install(); return false;"
href="https://clients2.google.com/service/update2/crx?response=redirect&x=id%3Dcfhdojbkjhnklbpkdaibdccddilifddb%26uc">Install
for yandex-browser</a>
The link leads to an error page. Since the `href` is only used in case of
JavaScript being disabled it makes more sense to link to the Chrome Web Store
page directly. (same above for the Chrome extension)

[Thomas Greiner, 2014-12-05 10:39:00]

One more thing that I just noticed…

http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/inde...
File index.html (right):

http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/inde...
index.html:46: <a id="install-yandex-browser" class="install-button"
onclick="chrome.webstore.install(); return false;"
href="https://clients2.google.com/service/update2/crx?response=redirect&x=id%3Dcfhdojbkjhnklbpkdaibdccddilifddb%26uc">Install
for yandex-browser</a>
Please use the actual name of the browser which is "Yandex.Browser" and not
"yandex-browser".

[saroyanm, 2014-12-07 14:06:01]

http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/inde...
File index.html (right):

http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/inde...
index.html:46: <a id="install-yandex-browser" class="install-button"
onclick="chrome.webstore.install(); return false;"
href="https://clients2.google.com/service/update2/crx?response=redirect&x=id%3Dcfhdojbkjhnklbpkdaibdccddilifddb%26uc">Install
for yandex-browser</a>
On 2014/12/05 10:24:49, Thomas Greiner wrote:
> The link leads to an error page. Since the `href` is only used in case of
> JavaScript being disabled it makes more sense to link to the Chrome Web Store
> page directly. (same above for the Chrome extension)

Good point.

http://codereview.adblockplus.org/6078704820158464/diff/5629499534213120/inde...
index.html:46: <a id="install-yandex-browser" class="install-button"
onclick="chrome.webstore.install(); return false;"
href="https://clients2.google.com/service/update2/crx?response=redirect&x=id%3Dcfhdojbkjhnklbpkdaibdccddilifddb%26uc">Install
for yandex-browser</a>
On 2014/12/05 10:39:00, Thomas Greiner wrote:
> Please use the actual name of the browser which is "Yandex.Browser" and not
> "yandex-browser".

Oops, I changed to "Yandex Browser" as was written in the description of the
ticket, anyway we can change to stylized version afterward in case.

[Thomas Greiner, 2014-12-08 14:43:38]

LGTM

[Wladimir Palant, 2014-12-11 22:02:08]

LGTM