Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(245)

Issue 6089170179063808: Issue 1976 - Handle prerendered tabs on Chrome (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by Sebastian Noack
Modified:
4 years, 8 months ago
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 1976 - Handle prerendered tab on Chrome

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -31 lines) Patch
M chrome/ext/background.js View 1 chunk +87 lines, -31 lines 6 comments Download

Messages

Total messages: 4
Sebastian Noack
4 years, 8 months ago (2015-02-08 12:01:05 UTC) #1
kzar
http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chrome/ext/background.js#newcode185 chrome/ext/background.js:185: this._applyChanges(); Woudln't `this` in this context be onReplaced instead ...
4 years, 8 months ago (2015-02-09 16:38:39 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chrome/ext/background.js#newcode185 chrome/ext/background.js:185: this._applyChanges(); On 2015/02/09 16:38:40, kzar wrote: > Woudln't `this` ...
4 years, 8 months ago (2015-02-09 17:03:24 UTC) #3
kzar
4 years, 8 months ago (2015-02-09 17:05:25 UTC) #4
LGTM

http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chro...
chrome/ext/background.js:185: this._applyChanges();
On 2015/02/09 17:03:24, Sebastian Noack wrote:
> On 2015/02/09 16:38:40, kzar wrote:
> > Woudln't `this` in this context be onReplaced instead of BrowserAction?
> 
> Mind the .bind() below. ;)

Whoops OK, missed that!

http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chro...
chrome/ext/background.js:192: this._applyChanges();
On 2015/02/09 17:03:24, Sebastian Noack wrote:
> On 2015/02/09 16:38:40, kzar wrote:
> > Nit: Don't really need the braces for the else clause here.
> 
> Some time ago Wladimir told me to add braces for the else-block if the
if-block
> requires braces and vice-versa.

Fair enough
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5