Issue 6089170179063808: Issue 1976 - Handle prerendered tabs on Chrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6089170179063808: Issue 1976 - Handle prerendered tabs on Chrome (Closed)

Created:
Feb. 8, 2015, 11:47 a.m. by Sebastian Noack

Modified:
Feb. 10, 2015, 9:23 a.m.

Reviewers:
kzar

CC:
Wladimir Palant

Visibility:
Public.

Description

Issue 1976 - Handle prerendered tab on Chrome

Patch Set 1 #

Total comments: 6

Created: Feb. 8, 2015, 11:47 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -31 lines)			Patch
	M	chrome/ext/background.js	View		1 chunk	+87 lines, -31 lines	6 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chrome/ext/background.js#newcode185 chrome/ext/background.js:185: this._applyChanges(); Woudln't `this` in this context be onReplaced instead ...

Feb. 9, 2015, 4:38 p.m. (2015-02-09 16:38:39 UTC) #2

Sebastian Noack

http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chrome/ext/background.js#newcode185 chrome/ext/background.js:185: this._applyChanges(); On 2015/02/09 16:38:40, kzar wrote: > Woudln't `this` ...

Feb. 9, 2015, 5:03 p.m. (2015-02-09 17:03:24 UTC) #3

kzar

Feb. 9, 2015, 5:05 p.m. (2015-02-09 17:05:25 UTC) #4

LGTM

http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chro...
chrome/ext/background.js:185: this._applyChanges();
On 2015/02/09 17:03:24, Sebastian Noack wrote:
> On 2015/02/09 16:38:40, kzar wrote:
> > Woudln't `this` in this context be onReplaced instead of BrowserAction?
> 
> Mind the .bind() below. ;)

Whoops OK, missed that!

http://codereview.adblockplus.org/6089170179063808/diff/5629499534213120/chro...
chrome/ext/background.js:192: this._applyChanges();
On 2015/02/09 17:03:24, Sebastian Noack wrote:
> On 2015/02/09 16:38:40, kzar wrote:
> > Nit: Don't really need the braces for the else clause here.
> 
> Some time ago Wladimir told me to add braces for the else-block if the
if-block
> requires braces and vice-versa.

Fair enough

Expand All Messages | Collapse All Messages