Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6099042538881024: Wait until images are loaded (Closed)

Created:
Nov. 16, 2013, 2 p.m. by Felix Dahlke
Modified:
Nov. 17, 2013, 6:11 a.m.
Visibility:
Public.

Description

When building ABP for Safari on my local machine or the build server, the result of Image.open was always none. It appears [1] that Image.open is lazy, and we need to call .load() to ensure that the image is actually loaded. Note that this is already pushed: https://hg.adblockplus.org/buildtools/rev/60153820143b [1] http://stackoverflow.com/a/12413650

Patch Set 1 #

Patch Set 2 : Also make sure the image is loaded in filter_blend(), add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M imageConversion.py View 1 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
Nov. 16, 2013, 2:08 p.m. (2013-11-16 14:08:32 UTC) #1
Sebastian Noack
Normally this isn't necessary. But some distros come with a broken or old version of ...
Nov. 16, 2013, 2:48 p.m. (2013-11-16 14:48:40 UTC) #2
Felix Dahlke
Alright, here's a new patch.
Nov. 16, 2013, 3:13 p.m. (2013-11-16 15:13:45 UTC) #3
Sebastian Noack
LGTM. Please remember to update .hgsubstate in sitescripts and adblockpluschrome. You forgot it, when you ...
Nov. 16, 2013, 3:19 p.m. (2013-11-16 15:19:56 UTC) #4
Wladimir Palant
Nov. 17, 2013, 6:11 a.m. (2013-11-17 06:11:40 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld