Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 6103027194789888: Integrated ABP for Safari into the nightly builds (Closed)

Created:
Nov. 12, 2013, 6:43 p.m. by Sebastian Noack
Modified:
Nov. 13, 2013, 3 p.m.
Visibility:
Public.

Description

Integrated ABP for Safari into the nightly builds

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adressed comment, fixed indentation #

Patch Set 3 : Added safari extension to .sitescripts.example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M .hgsubstate View 1 chunk +1 line, -1 line 0 comments Download
M .sitescripts.example View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 4 chunks +35 lines, -0 lines 0 comments Download
A sitescripts/extensions/template/updates.plist View 1 1 chunk +22 lines, -0 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Sebastian Noack
Nov. 12, 2013, 6:43 p.m. (2013-11-12 18:43:54 UTC) #1
Sebastian Noack
Nov. 12, 2013, 6:46 p.m. (2013-11-12 18:46:22 UTC) #2
Wladimir Palant
Please add safariUpdateManifest to .sitescripts.example. LGTM with this and the nit below fixed. http://codereview.adblockplus.org/6103027194789888/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py File ...
Nov. 13, 2013, 11:53 a.m. (2013-11-13 11:53:24 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/6103027194789888/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/6103027194789888/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py#newcode190 sitescripts/extensions/bin/createNightlies.py:190: m = re.match(r'Safari Developer: \((.*?)\)', entry.get_data().as_text()) On 2013/11/13 11:53:24, ...
Nov. 13, 2013, 11:55 a.m. (2013-11-13 11:55:55 UTC) #4
Sebastian Noack
Nov. 13, 2013, 1:20 p.m. (2013-11-13 13:20:39 UTC) #5
Wladimir Palant
http://codereview.adblockplus.org/6103027194789888/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/6103027194789888/diff/5629499534213120/sitescripts/extensions/bin/createNightlies.py#newcode190 sitescripts/extensions/bin/createNightlies.py:190: m = re.match(r'Safari Developer: \((.*?)\)', entry.get_data().as_text()) On 2013/11/13 11:55:55, ...
Nov. 13, 2013, 1:21 p.m. (2013-11-13 13:21:13 UTC) #6
Wladimir Palant
The new patchset looks fine but there is still no change to .sitescript.examples
Nov. 13, 2013, 1:22 p.m. (2013-11-13 13:22:02 UTC) #7
Sebastian Noack
Nov. 13, 2013, 1:34 p.m. (2013-11-13 13:34:07 UTC) #8
Wladimir Palant
Still LGTM
Nov. 13, 2013, 1:56 p.m. (2013-11-13 13:56:56 UTC) #9
Felix Dahlke
Nov. 13, 2013, 3 p.m. (2013-11-13 15:00:28 UTC) #10 
LGTM. Just skimmed things Wladimir's in-depth review should suffice.

Powered by Google App Engine
This is Rietveld