Issue 1495 - Introduce $sitescriptsini_content in Puppet sitescripts module

See https://issues.adblockplus.org/ticket/1495.

Note that there's a duplicate of this review ticket (http://codereview.adblockplus.org/5814178002501632/), obviously a confusion with the numbers on my side.

[Wladimir Palant, 2014-11-26 22:47:08]

http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modu...
File modules/sitescripts/manifests/init.pp (right):

http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modu...
modules/sitescripts/manifests/init.pp:18: ';'     => $title,
Why not:

  source => "$source$content" ? {
    '' => $title,

Seems more obvious.

[mathias, 2014-11-26 23:34:29]

http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modu...
File modules/sitescripts/manifests/init.pp (right):

http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modu...
modules/sitescripts/manifests/init.pp:18: ';'     => $title,
On 2014/11/26 22:47:09, Wladimir Palant wrote:
> Why not:
> 
>   source => "$source$content" ? {
>     '' => $title,
> 
> Seems more obvious.

I would agree on "more common" rather than "more obvious", but also "less
readable". To answer your question: No reason other than personal preference. Do
you insist on the empty string version? ;)

[Wladimir Palant, 2014-12-08 16:43:59]

http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modu...
File modules/sitescripts/manifests/init.pp (right):

http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modu...
modules/sitescripts/manifests/init.pp:18: ';'     => $title,
On 2014/11/26 23:34:29, matze wrote:
> To answer your question: No reason other than personal preference. Do
> you insist on the empty string version? ;)

I do :)

In fact, I asked Sebastian as somebody who isn't familiar with the code - and he
perceived the variant without a semicolon as more readable. In fact, the empty
string indicates that testing for empty strings is what we are doing here.

[mathias, 2014-12-10 12:51:04]

http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modu...
File modules/sitescripts/manifests/init.pp (right):

http://codereview.adblockplus.org/6122106488094720/diff/5629499534213120/modu...
modules/sitescripts/manifests/init.pp:18: ';'     => $title,
On 2014/12/08 16:44:00, Wladimir Palant wrote:
> On 2014/11/26 23:34:29, matze wrote:
> > To answer your question: No reason other than personal preference. Do
> > you insist on the empty string version? ;)
> 
> I do :)
> 
> In fact, I asked Sebastian as somebody who isn't familiar with the code - and
he
> perceived the variant without a semicolon as more readable. In fact, the empty
> string indicates that testing for empty strings is what we are doing here.

Done.

[Wladimir Palant, 2014-12-11 16:47:34]

LGTM