Issue 6136997097766912: Fallback to the top-level frame if we don't know the frame on Chrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6136997097766912: Fallback to the top-level frame if we don't know the frame on Chrome (Closed)

Created:
Jan. 23, 2014, 8:57 a.m. by Sebastian Noack

Modified:
Jan. 23, 2014, 10:17 a.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

Frames with javascript: or data: URL bypass Chrome's webrequest API. In addition to not being able to block those frames they currently break the frame hierarchy we rely on for some blocking and whitelisting rules. This is a regression in the current devbuild. Before we just assumed to be in the top-level frame when encountering an unknown frame. This isn't optimal but fixes at least most domain-based filter rules. So I have added that approach again.

Patch Set 1 #

Created: Jan. 23, 2014, 8:57 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	chrome/ext/background.js	View		1 chunk	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages