block.html - Issue 6194726097125376: Issue 731 - Don't wrap filter in "Block element" dialog

Delta Between Two Patch Sets: block.html

Issue 6194726097125376: Issue 731 - Don't wrap filter in "Block element" dialog (Closed)

Left Patch Set: Created June 28, 2014, 1:14 p.m.

Right Patch Set: Addressed comment Created Oct. 29, 2014, 12:15 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2	2

3 <!--	3 <!--

4 - This file is part of Adblock Plus <http://adblockplus.org/>,	4 - This file is part of Adblock Plus <http://adblockplus.org/>,

5 - Copyright (C) 2006-2014 Eyeo GmbH	5 - Copyright (C) 2006-2014 Eyeo GmbH

6 -	6 -

7 - Adblock Plus is free software: you can redistribute it and/or modify	7 - Adblock Plus is free software: you can redistribute it and/or modify

8 - it under the terms of the GNU General Public License version 3 as	8 - it under the terms of the GNU General Public License version 3 as

9 - published by the Free Software Foundation.	9 - published by the Free Software Foundation.

10 -	10 -

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 }	49 }

50 #title > img	50 #title > img

51 {	51 {

52 margin-right: 5px;	52 margin-right: 5px;

53 }	53 }

54 #filters	54 #filters

55 {	55 {

56 width: 400px;	56 width: 400px;

57 height: 100px;	57 height: 100px;

58 resize: none;	58 resize: none;

	59 white-space: pre;

	60 word-wrap: normal;

59 }	61 }

60 #buttons	62 #buttons

61 {	63 {

62 text-align: right;	64 text-align: right;

63 }	65 }

64 button	66 button

65 {	67 {

66 padding: 3px !important;	68 padding: 3px !important;

67 }	69 }

68 </style>	70 </style>

69 </head>	71 </head>

70 <body draggable="true">	72 <body draggable="true">

71	73

72 <div id="title">	74 <div id="title">

73 <img src="icons/abp-32.png" />	75 <img src="icons/abp-32.png" />

74 <span class="i18n_add_filters_msg"></span>	76 <span class="i18n_add_filters_msg"></span>

75 </div>	77 </div>

76	78

77 <textarea id="filters" wrap="off"></textarea>	79 <textarea id="filters"></textarea>
Thomas Greiner 2014/09/30 10:37:00 This works but the "off" value doesn't appear to b This works but the "off" value doesn't appear to be in the standard. We can achieve the same effect with CSS using: white-space: pre; word-wrap: normal; Sebastian Noack 2014/10/01 18:15:08 Well, it is in the standard: https://html.spec.wha Show quoted text On 2014/09/30 10:37:00, Thomas Greiner wrote: > This works but the "off" value doesn't appear to be in the standard. We can > achieve the same effect with CSS using: > > white-space: pre; > word-wrap: normal; Well, it is in the standard: https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap It's also documented on MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap Wladimir Palant 2014/10/01 18:35:51 Either I am overlooking something or both pages on Show quoted text On 2014/10/01 18:15:08, Sebastian Noack wrote: > Well, it is in the standard: > https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap > > It's also documented on MDN: > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap Either I am overlooking something or both pages only document wrap="hard" and wrap="soft" but not wrap="off". This value indeed appears to be non-standard and deprecated. Sebastian Noack 2014/10/29 12:17:05 No, I overlooked it, you both were right. I'm usin Show quoted text On 2014/10/01 18:35:51, Wladimir Palant wrote: > On 2014/10/01 18:15:08, Sebastian Noack wrote: > > Well, it is in the standard: > > https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap > > > > It's also documented on MDN: > > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap > > Either I am overlooking something or both pages only document wrap="hard" and > wrap="soft" but not wrap="off". This value indeed appears to be non-standard and > deprecated. No, I overlooked it, you both were right. I'm using standard CSS properties now, as suggested by Thomas.
78	80

79 <div id="buttons">	81 <div id="buttons">

80 <button id="addButton" class="i18n_add"></button>	82 <button id="addButton" class="i18n_add"></button>

81 <button id="cancelButton" class="i18n_cancel"></button>	83 <button id="cancelButton" class="i18n_cancel"></button>

82 </div>	84 </div>

83	85

84 </body>	86 </body>

85 </html>	87 </html>

LEFT	RIGHT