Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6194726097125376: Issue 731 - Don't wrap filter in "Block element" dialog (Closed)

Created:
June 28, 2014, 1:14 p.m. by Sebastian Noack
Modified:
Dec. 9, 2014, 9:27 p.m.
Visibility:
Public.

Description

Issue 731 - Don't wrap filter in "Block element" dialog

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M block.html View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
June 28, 2014, 1:15 p.m. (2014-06-28 13:15:00 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/block.html#newcode77 block.html:77: <textarea id="filters" wrap="off"></textarea> This works but the "off" value ...
Sept. 30, 2014, 10:36 a.m. (2014-09-30 10:36:59 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/block.html#newcode77 block.html:77: <textarea id="filters" wrap="off"></textarea> On 2014/09/30 10:37:00, Thomas Greiner wrote: ...
Oct. 1, 2014, 6:15 p.m. (2014-10-01 18:15:08 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/block.html#newcode77 block.html:77: <textarea id="filters" wrap="off"></textarea> On 2014/10/01 18:15:08, Sebastian Noack wrote: ...
Oct. 1, 2014, 6:35 p.m. (2014-10-01 18:35:50 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/block.html File block.html (right): http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/block.html#newcode77 block.html:77: <textarea id="filters" wrap="off"></textarea> On 2014/10/01 18:35:51, Wladimir Palant wrote: ...
Oct. 29, 2014, 12:17 p.m. (2014-10-29 12:17:05 UTC) #5
Thomas Greiner
LGTM
Oct. 29, 2014, 1:03 p.m. (2014-10-29 13:03:48 UTC) #6
Wladimir Palant
Dec. 9, 2014, 9:27 p.m. (2014-12-09 21:27:10 UTC) #7
Better late than never: LGTM

Powered by Google App Engine
This is Rietveld