Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1253)

Issue 6202981292703744: Whole installer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by Oleksandr
Modified:
4 years, 5 months ago
Reviewers:
sergei, Felix Dahlke, Eric
Visibility:
Public.

Description

Whole installer. Since rietveld can't handle an upload of a review with a lot of files I have removed the localization files (installer/src/msi/locale folder). There wasn't much sense in reviewing that anyway.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6745 lines, -768 lines) Patch
M .hgsubstate View 1 chunk +1 line, -1 line 0 comments Download
M README.md View 1 chunk +13 lines, -0 lines 0 comments Download
M build_release.py View 2 chunks +13 lines, -16 lines 2 comments Download
M html/static/js/firstRun.js View 1 chunk +1 line, -1 line 0 comments Download
M html/templates/firstRun.html View 1 chunk +1 line, -1 line 0 comments Download
R installer/1031/bootstrap-theme.wxl View 1 chunk +0 lines, -50 lines 0 comments Download
M installer/Makefile View 1 chunk +138 lines, -133 lines 0 comments Download
M installer/createsolutions.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A installer/emb.vbs View 1 chunk +40 lines, -0 lines 0 comments Download
R installer/en-us.wxl View 1 chunk +0 lines, -14 lines 0 comments Download
A installer/googletest.gyp View 1 chunk +91 lines, -0 lines 0 comments Download
A installer/install.cmd View 1 chunk +65 lines, -0 lines 0 comments Download
M installer/installer.gyp View 1 chunk +849 lines, -65 lines 0 comments Download
A installer/msibuild.cmd View 1 chunk +89 lines, -0 lines 0 comments Download
M installer/src/custom-action/abp_ca.def View 1 chunk +1 line, -1 line 0 comments Download
M installer/src/custom-action/close_application.cpp View 1 chunk +430 lines, -16 lines 0 comments Download
A installer/src/custom-action/close_ie.wxi View 1 chunk +30 lines, -0 lines 0 comments Download
A installer/src/custom-action/close_ie_default.wxl View 1 chunk +12 lines, -0 lines 0 comments Download
A installer/src/custom-action/test/test-close-application.wxs View 1 chunk +827 lines, -0 lines 0 comments Download
A installer/src/documentation/build_process.dox View 1 chunk +110 lines, -0 lines 0 comments Download
A installer/src/documentation/localization.dox View 1 chunk +219 lines, -0 lines 0 comments Download
M installer/src/documentation/mainpage.dox View 1 chunk +38 lines, -1 line 0 comments Download
A installer/src/documentation/source_code.dox View 1 chunk +108 lines, -0 lines 0 comments Download
A installer/src/innosetup-exe/64BitTwoArch.iss View 1 chunk +60 lines, -0 lines 0 comments Download
M installer/src/installer-lib/DLL.h View 2 chunks +24 lines, -24 lines 0 comments Download
M installer/src/installer-lib/DLL.cpp View 3 chunks +14 lines, -18 lines 0 comments Download
A installer/src/installer-lib/custom-i18n.h View 1 chunk +47 lines, -0 lines 0 comments Download
A installer/src/installer-lib/custom-i18n.wxi View 1 chunk +24 lines, -0 lines 0 comments Download
M installer/src/installer-lib/database.h View 1 chunk +170 lines, -40 lines 0 comments Download
M installer/src/installer-lib/database.cpp View 3 chunks +70 lines, -31 lines 0 comments Download
A installer/src/installer-lib/handle.h View 1 chunk +276 lines, -0 lines 0 comments Download
A installer/src/installer-lib/installer-lib.h View 1 chunk +114 lines, -0 lines 0 comments Download
M installer/src/installer-lib/interaction.h View 1 chunk +98 lines, -2 lines 0 comments Download
M installer/src/installer-lib/interaction.cpp View 1 chunk +24 lines, -8 lines 0 comments Download
A installer/src/installer-lib/process.h View 1 chunk +707 lines, -0 lines 0 comments Download
A installer/src/installer-lib/process.cpp View 1 chunk +301 lines, -0 lines 0 comments Download
M installer/src/installer-lib/property.h View 2 chunks +79 lines, -79 lines 0 comments Download
M installer/src/installer-lib/property.cpp View 3 chunks +27 lines, -25 lines 0 comments Download
M installer/src/installer-lib/record.h View 1 chunk +223 lines, -49 lines 0 comments Download
M installer/src/installer-lib/record.cpp View 2 chunks +60 lines, -8 lines 0 comments Download
A installer/src/installer-lib/run-tests.cmd View 1 chunk +7 lines, -0 lines 0 comments Download
M installer/src/installer-lib/session.h View 6 chunks +168 lines, -84 lines 0 comments Download
M installer/src/installer-lib/session.cpp View 1 chunk +74 lines, -31 lines 0 comments Download
A installer/src/installer-lib/test/custom-action-fail.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/database_test.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/exception_test.cpp View 1 chunk +58 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/process_test.cpp View 1 chunk +316 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/property_test.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/record_test.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib.wxs View 1 chunk +126 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib-ca.cpp View 1 chunk +71 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib-ca.def View 1 chunk +13 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib-ca.rc View 1 chunk +26 lines, -0 lines 0 comments Download
A installer/src/installer-lib/test/test-installer-lib-sandbox.cpp View 1 chunk +142 lines, -0 lines 0 comments Download
M installer/src/msi/adblockplusie.wxs View 13 chunks +75 lines, -17 lines 0 comments Download
M installer/src/msi/bho_registry_value.wxi View 0 chunks +-1 lines, --1 lines 0 comments Download
M installer/src/msi/custom_WixUI_InstallDir.wxs View 0 chunks +-1 lines, --1 lines 0 comments Download
M installer/src/msi/dll_class.wxi View 0 chunks +-1 lines, --1 lines 0 comments Download
M installer/src/setup-exe/abp-64.png View Binary file 0 comments Download
M installer/src/setup-exe/bootstrap-theme.wxl View 0 chunks +-1 lines, --1 lines 0 comments Download
M installer/src/setup-exe/bootstrap-theme.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M installer/src/setup-exe/setup.wxs View 2 chunks +14 lines, -13 lines 0 comments Download
M src/engine/Main.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/AdblockPlusClient.cpp View 1 chunk +16 lines, -7 lines 0 comments Download
M src/shared/Communication.cpp View 4 chunks +62 lines, -36 lines 0 comments Download
M src/shared/Utils.h View 1 chunk +21 lines, -0 lines 0 comments Download
M src/shared/Utils.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M test/CommunicationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/DictionaryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Oleksandr
5 years ago (2014-06-24 07:31:06 UTC) #1
Felix Dahlke
Doing a full review of this before the release is not realistic, so I tried ...
4 years, 11 months ago (2014-08-07 15:15:04 UTC) #2
Eric
4 years, 11 months ago (2014-08-07 15:52:35 UTC) #3
http://codereview.adblockplus.org/6202981292703744/diff/5629499534213120/buil...
File build_release.py (left):

http://codereview.adblockplus.org/6202981292703744/diff/5629499534213120/buil...
build_release.py:69: bundle = os.path.join(basedir, "build",
"adblockplusie-%s.exe" % version)
On 2014/08/07 15:15:04, Felix H. Dahlke wrote:
> Why don't we sign the individual .exes anymore? Is signing the MSIs and
> installer sufficient?

Wladimir figured out the signing issues a year ago on first release, which was
using WiX burn. WiX burn is too problematic for a number of reasons for
packaging MSI's, so Oleksandr switched just that one part over to InnoSetup. The
new signing tool is from InnoSetup. At the very least, it has different syntax.

I can't say whether it's the right kind of signing or not.

One thing we had talked about but have not done yet (to my knowledge) is to
generate a development-only signing key, checked into version control, that we
can use to test the signing procedure.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5