Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6213126861094912: Issue 2575 - Promo image missing after migration (Closed)

Created:
May 22, 2015, 1:05 p.m. by saroyanm
Modified:
May 22, 2015, 3:22 p.m.
Reviewers:
Sebastian Noack
CC:
Felix Dahlke
Visibility:
Public.

Description

Related ticket: https://issues.adblockplus.org/ticket/2575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A static/img/adblockplus_promo.png View Binary file 0 comments Download

Messages

Total messages: 5
saroyanm
Sebastian can you please have a look.
May 22, 2015, 1:07 p.m. (2015-05-22 13:07:14 UTC) #1
Sebastian Noack
LGTM, assuming this image has been compressed with pngout. Does it?
May 22, 2015, 2:05 p.m. (2015-05-22 14:05:22 UTC) #2
saroyanm
On 2015/05/22 14:05:22, Sebastian Noack wrote: > LGTM, assuming this image has been compressed with ...
May 22, 2015, 2:08 p.m. (2015-05-22 14:08:31 UTC) #3
Sebastian Noack
On 2015/05/22 14:08:31, saroyanm wrote: > On 2015/05/22 14:05:22, Sebastian Noack wrote: > > LGTM, ...
May 22, 2015, 3:11 p.m. (2015-05-22 15:11:55 UTC) #4
saroyanm
May 22, 2015, 3:22 p.m. (2015-05-22 15:22:18 UTC) #5
On 2015/05/22 15:11:55, Sebastian Noack wrote:
> On 2015/05/22 14:08:31, saroyanm wrote:
> > On 2015/05/22 14:05:22, Sebastian Noack wrote:
> > > LGTM, assuming this image has been compressed with pngout. Does it?
> > 
> > Yes it is :) After your prev comment regarding compression, always
processing
> > through.
> 
> Good boy. :D

:D

Powered by Google App Engine
This is Rietveld