Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 6221488373891072: remove atlthunk library because there is no such library, and it works without it (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by sergei
Modified:
5 years, 4 months ago
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

remove atlthunk library because there is no such library, and it works without it https://issues.adblockplus.org/ticket/974

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M adblockplus.gyp View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 2
Oleksandr
LGTM http://codereview.adblockplus.org/6221488373891072/diff/5629499534213120/adblockplus.gyp File adblockplus.gyp (left): http://codereview.adblockplus.org/6221488373891072/diff/5629499534213120/adblockplus.gyp#oldcode107 adblockplus.gyp:107: '-latlthunk', atlthink.lib is a file from Windows Driver ...
5 years, 4 months ago (2014-07-15 09:03:19 UTC) #1
Felix Dahlke
5 years, 4 months ago (2014-07-16 00:27:57 UTC) #2
LGTM, assuming we can still build with VS Express.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5