Issue 212 - Update Discourse

Still have to go through all the site settings. In particular, it seems that email_domains_blacklist and email_domains_whitelist are gone which would be an issue.

[Felix Dahlke, 2014-03-27 15:49:10]

LGTM, assuming it works :) Good thing you made the domain configurable, didn't
like hard coding that one.

http://codereview.adblockplus.org/6221863587938304/diff/5629499534213120/modu...
File modules/discourse/manifests/init.pp (right):

http://codereview.adblockplus.org/6221863587938304/diff/5629499534213120/modu...
modules/discourse/manifests/init.pp:3: $is_default = false) inherits
private::discourse {
Nit: We usually break before ")" in argument lists, I think.

[Wladimir Palant, 2014-03-27 20:28:24]

I went through the site settings and found that use_ssl is now called use_https
- other than that all our settings are fine. I added two new settings that seem
to make sense. I also made sure changes to site settings restart Discourse -
currently that's the only reliable way for them to be picked up.

http://codereview.adblockplus.org/6221863587938304/diff/5629499534213120/modu...
File modules/discourse/manifests/init.pp (right):

http://codereview.adblockplus.org/6221863587938304/diff/5629499534213120/modu...
modules/discourse/manifests/init.pp:3: $is_default = false) inherits
private::discourse {
On 2014/03/27 15:49:11, Felix H. Dahlke wrote:
> Nit: We usually break before ")" in argument lists, I think.

From what I can tell, the only other occasions are nginx (there we have a line
break) and trac (there we don't have it). But I guess having a line break would
be consistent with the usual Puppet style, done. We might want to change it in
the Trac module as well when we touch it.

[Wladimir Palant, 2014-03-27 22:17:24]

Fixed an issue: /opt/discourse/tmp being created before the fetch_discourse
command prevented Mercurial from cloning (/opt/discourse directory not empty).

Also added packages required by the Ruby gems and cleaned up the code a bit.

[Wladimir Palant, 2014-03-27 23:09:52]

Also removed post action types now - Discourse will initialize these
automatically.

[Wladimir Palant, 2014-03-28 08:58:05]

The new patch fixes service path in a few places - that issue would have only
become apparent on update, so it didn't pop up during initial provisioning.

[Felix Dahlke, 2014-03-28 15:39:12]

LGTM