Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6231623137755136: Issue 2605 - Redirect legacy update URLs (Closed)

Created:
May 28, 2015, 11:40 a.m. by Wladimir Palant
Modified:
May 28, 2015, 12:22 p.m.
Reviewers:
mathias, Felix Dahlke
Visibility:
Public.

Description

Issue 2605 - Redirect legacy update URLs

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M modules/web/templates/adblockplus.org.conf.erb View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
May 28, 2015, 11:40 a.m. (2015-05-28 11:40:12 UTC) #1
mathias
LGTM.
May 28, 2015, 11:44 a.m. (2015-05-28 11:44:45 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/6231623137755136/diff/5629499534213120/modules/web/templates/adblockplus.org.conf.erb File modules/web/templates/adblockplus.org.conf.erb (right): http://codereview.adblockplus.org/6231623137755136/diff/5629499534213120/modules/web/templates/adblockplus.org.conf.erb#newcode76 modules/web/templates/adblockplus.org.conf.erb:76: rewrite ^/androidupdate.xml$ https://update.adblockplus.org/adblockplusandroid/updates.xml permanent; Isn't that androidupdates.xml, with an ...
May 28, 2015, 11:50 a.m. (2015-05-28 11:50:35 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6231623137755136/diff/5629499534213120/modules/web/templates/adblockplus.org.conf.erb File modules/web/templates/adblockplus.org.conf.erb (right): http://codereview.adblockplus.org/6231623137755136/diff/5629499534213120/modules/web/templates/adblockplus.org.conf.erb#newcode76 modules/web/templates/adblockplus.org.conf.erb:76: rewrite ^/androidupdate.xml$ https://update.adblockplus.org/adblockplusandroid/updates.xml permanent; On 2015/05/28 11:50:35, Felix H. ...
May 28, 2015, 11:57 a.m. (2015-05-28 11:57:44 UTC) #4
Felix Dahlke
May 28, 2015, 12:04 p.m. (2015-05-28 12:04:31 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld