Issue 2578 - Refactored and added missing hidden import

Issue 2578 - Refactored and added missing hidden import

[Sebastian Noack, 2015-05-22 21:19:27]

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
File runserver.py (left):

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
runserver.py:2: # This is a stub script loading test_server module, used by
PyInstaller.
This script is no longer needed as wrapper for PyInstaller. But I left it there
for inconvenience. Figuring out the command line everytime you run the server as
a script, would be quite annoying.

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
File runserver.spec (right):

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
runserver.spec:6: def AnalysisWithHiddenImportsWorkaround(scripts, **kwargs):
Yeah, as the comment says, the hiddenimports passed to Analysis, are supposed to
be analyzed recursively. This bug has recently been fixed in PyInstaller, but
the last release was in 2013. :(

However, we can already achieve that behavior by generating a script importing
the hidden modules, have PyInstaller analyze it, and removing the script
afterwards.

This is has the advantage, that hidden imports aren't performed in adavance. In
particular with modules (like minidom) that are only included for particular
websites, importing them no matter what seemed wrong to me. And once a new
version of PyInstaller is released we can simply remove the workaround.

[Sebastian Noack, 2015-05-22 21:20:10]

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
File runserver.py (left):

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
runserver.py:2: # This is a stub script loading test_server module, used by
PyInstaller.
On 2015/05/22 21:19:27, Sebastian Noack wrote:
> This script is no longer needed as wrapper for PyInstaller. But I left it
there
> for inconvenience. Figuring out the command line everytime you run the server
as
> a script, would be quite annoying.

Heh, I meant for convenience of course. ;)

[Wladimir Palant, 2015-05-26 10:46:31]

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
File runserver.spec (right):

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
runserver.spec:15: a.scripts -= [('_hidden_imports', None, None)]
Shouldn't we remove _hidden_imports.py here?

[Sebastian Noack, 2015-05-26 11:13:57]

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
File runserver.spec (right):

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
runserver.spec:15: a.scripts -= [('_hidden_imports', None, None)]
On 2015/05/26 10:46:31, Wladimir Palant wrote:
> Shouldn't we remove _hidden_imports.py here?

The first element is the module name, not the file name.

[Wladimir Palant, 2015-05-26 11:24:43]

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
File runserver.spec (right):

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
runserver.spec:15: a.scripts -= [('_hidden_imports', None, None)]
On 2015/05/26 11:13:57, Sebastian Noack wrote:
> The first element is the module name, not the file name.

And I mean the file - the one you created on disk, and that is currently being
left around.

[Sebastian Noack, 2015-05-26 11:37:39]

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
File runserver.spec (right):

http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runs...
runserver.spec:15: a.scripts -= [('_hidden_imports', None, None)]
On 2015/05/26 11:24:43, Wladimir Palant wrote:
> On 2015/05/26 11:13:57, Sebastian Noack wrote:
> > The first element is the module name, not the file name.
> 
> And I mean the file - the one you created on disk, and that is currently being
> left around.

Along with some other temporary files in the build directory.  That should be
fine.

[Wladimir Palant, 2015-05-26 11:43:48]

LGTM