Issue 6246174612783104: Issue 535 - Contact form cannot deal with commas in sender`s name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6246174612783104: Issue 535 - Contact form cannot deal with commas in sender`s name (Closed)

Created:
May 22, 2014, 8:13 a.m. by Wladimir Palant

Modified:
May 23, 2014, 1:28 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue 535 - Contact form cannot deal with commas in sender`s name

Patch Set 1 #

Total comments: 2

Created: May 22, 2014, 8:13 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
M	sitescripts/formmail/template/eyeo.mail	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/reports/bin/mailDigests.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sitescripts/templateFilters.py	View	3 chunks	+9 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Sebastian Noack

LGTM, with nit addressed. http://codereview.adblockplus.org/6246174612783104/diff/5629499534213120/sitescripts/templateFilters.py File sitescripts/templateFilters.py (right): http://codereview.adblockplus.org/6246174612783104/diff/5629499534213120/sitescripts/templateFilters.py#newcode185 sitescripts/templateFilters.py:185: 'emailaddr': emailaddr, There is no ...

May 23, 2014, 1:16 p.m. (2014-05-23 13:16:18 UTC) #2

Wladimir Palant

May 23, 2014, 1:28 p.m. (2014-05-23 13:28:29 UTC) #3

http://codereview.adblockplus.org/6246174612783104/diff/5629499534213120/site...
File sitescripts/templateFilters.py (right):

http://codereview.adblockplus.org/6246174612783104/diff/5629499534213120/site...
sitescripts/templateFilters.py:185: 'emailaddr': emailaddr,
On 2014/05/23 13:16:18, Sebastian Noack wrote:
> There is no need to define the emailaddr function above. You can directly use
> email.utils.formataddr here:
> 
>   'emailaddr': email.utils.formataddr,

True, in the initial version this wasn't the case.

Expand All Messages | Collapse All Messages